Skip to content

Do not display the "from" section for the first exception trace entry #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2018
Merged

Do not display the "from" section for the first exception trace entry #109

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9da91f3
Do not display the "from" section for the first exception trace entry
morozov Nov 29, 2017
f8a4493
Switched to Ubuntu Precise on Travis CI, added dependency oh PHPUnit …
morozov Feb 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not display the "from" section for the first exception trace entry 
According to http://php.net/manual/en/exception.gettrace.php#107563, the first entry may not contain the file/line keys.

Additionally, some changes to the output formatting have been made:

1. The trace entries are counted in a human-friendly way starting with "1" (like Xdebug does for example).
2. The file name and line number in the "from" section are delimited by a colon without the space. This format is better IDE/editor friendly and helps easier navigation (e.g. Ctrl+N in PhpStorm, copy-paste the file:line combination).

Fixes #108.
  • Loading branch information
@morozov
morozov committed Nov 30, 2017
commit 9da91f3b2610b5cd27975a3a7c197714cadd452b
21 changes: 18 additions & 3 deletions src/ExceptionPrinter/DevelopmentExceptionPrinter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,23 @@ public function dumpTrace(Exception $e)

$argDesc = $this->dumpArgs($entry['args']);

$this->logger->info(sprintf(" %d) %s%s%s(%s)", $idx, @$entry['class'], @$entry['type'], $entry['function'], $argDesc));
$this->logger->info(sprintf(" from %s: %d", $entry['file'], $entry['line']));
$this->logger->info(sprintf(
" %d) %s%s%s(%s)",
$idx + 1,
@$entry['class'],
@$entry['type'],
$entry['function'],
$argDesc
));

if (isset($entry['file'], $entry['line'])) {
$this->logger->info(sprintf(
" from %s: %d",
$entry['file'],
$entry['line']
));
}

$this->logger->newline();
}
$this->logger->newline();
Expand Down Expand Up @@ -141,7 +156,7 @@ public function dumpBrief(Exception $e)
}
}

public function dump(Exception $e)
public function dump(Exception $e)
{
$this->dumpBrief($e);
$this->dumpCodeBlock($e);
Expand Down