Add the 3.x Patch #125

peter279k · 2022-12-14T17:03:51Z

Changed log

PHP 8.1 compatibility fix and it's the patch for the PHPBrew dependency.
Some changes are referenced by the 4.x version branch changes.

composer.json

src/Command/ArchiveCommand.php

src/CommandBase.php

src/Completion/ZshGenerator.php

peter279k · 2022-12-14T17:06:29Z

src/Component/Table/Table.php

        $columns = array(count($this->headers));
        foreach ($this->rows as $row) {
+            if (!is_array($row)) {
+                $row = [];


peter279k · 2022-12-14T17:06:50Z

src/OptionPrinter.php

 use GetOptionKit\OptionCollection;
 use GetOptionKit\Option;
-use GetOptionKit\OptionPrinter\OptionPrinterInterface;
+use GetOptionKit\OptionPrinter\OptionPrinter as OptionPrinterInterface;


https://github.com/c9s/GetOptionKit/blob/master/src/OptionPrinter/OptionPrinter.php#L8

peter279k · 2022-12-14T17:08:02Z

src/Testing/ConsoleTestCase.php

        @fclose($pipes[1]);
        @fclose($pipes[2]);
-        @pclose($process);
+        @proc_close($process);


Refer: https://github.com/c9s/CLIFramework/blob/master/src/Testing/ConsoleTestCase.php

peter279k · 2022-12-14T17:08:22Z

tests/CLIFramework/Component/Table/TableTest.php

            echo $str , "\n";
        }
-        parent::assertStringEqualsFile($file, $str, $message, $canonicalize, $ignoreCase);
+        parent::assertStringEqualsFile($file, $str, (string)$message, $canonicalize, $ignoreCase);


peter279k · 2022-12-14T17:08:47Z

tests/CLIFramework/IO/ReadlineConsoleTest.php


    function testReadPassword()
    {
+        $this->markTestSkipped('there is a bug in the php7 readline extension ');


Refer: https://github.com/c9s/CLIFramework/blob/master/tests/CLIFramework/IO/ReadlineConsoleTest.php

peter279k · 2022-12-14T17:09:06Z

tests/CLIFramework/IO/StandardConsoleTest.php

    {
+        if (!extension_loaded('readline')) {
+            $this->markTestSkipped("readline is required.");
+        }


Refer: https://github.com/c9s/CLIFramework/blob/master/tests/CLIFramework/IO/StandardConsoleTest.php

peter279k · 2022-12-14T17:10:06Z

tests/script/CLIFramework/IO/StandardConsoleReadLine.php

 $input = new CLIFramework\IO\StandardConsole($stty);
-$line = $input->readLine('');
-echo $line;
+echo $input->readLine('');


Refer: https://github.com/c9s/CLIFramework/blob/master/tests/script/CLIFramework/IO/StandardConsoleReadLine.php

peter279k · 2022-12-14T17:11:25Z

tests/helpers.php

 }

-function file_equals($e,$v,$msg = null)
+function file_equals($e,$v,$msg = '')


Refer: c9s/PHPUnit_TestMore@b7c053d

peter279k · 2022-12-15T02:23:44Z

tests/CLIFramework/ConsoleInfo/TputConsoleInfoTest.php


-class TputConsoleInfoTest extends PHPUnit_Framework_TestCase
+/**
+ * @group github_action


It can avoid the following message when running the GitHub workflows:

tput: No value for $TERM and no -T specified

Add the 3.x Patch

01cee2d