Enable custom validator on Option

[ErikBooij]

The customer validator you could set on an Option wasn't triggered during option parsing, this required you to call $option->validate($option->value)) manually, which is cumbersome and counterintuitive.

Sidenote: I noticed PHPUnit wasn't included as a dependency in composer.json, any reason for that? It's hard to run the unit tests that way ;-)

[c9s]

Thanks

The reason that phpunit was not added to the composer.json is that, I usually run the phpunit phar file directly

[ErikBooij]

Ah, I see. Fair enough. I think for contributors it's easier to include it, but it's not that much of a hassle to install it in the project locally and just not commit it.

[c9s]

you can add it to the dev dependency if it's more convenient

[coveralls]

Coverage increased (+0.008%) to 97.864% when pulling 65c83ae on ErikBooij:master into aa05d77 on c9s:master.

[coveralls]

Coverage increased (+0.008%) to 97.864% when pulling 65c83ae on ErikBooij:master into aa05d77 on c9s:master.

[coveralls]

Coverage increased (+0.008%) to 97.864% when pulling 6602b2d on ErikBooij:master into aa05d77 on c9s:master.

[c9s]

@ErikBooij I just tagged a release for this fix https://github.com/c9s/GetOptionKit/releases/tag/2.5.1

[morozov]

This change breaks compatibility with PHP 5.3 which is still declared in composer.json. @c9s do you want to bump PHP requirements or fix this issue?

[c9s]

@morozov shall we use an extra variable to improve the compatibility?

[morozov]

Yes, I believe it will work.