(WIP) Resource table v2 (no migration needed)#12237
Draft
dippindots wants to merge 2 commits into
Draft
Conversation
Cherry-picked from resource-table-enhancement branch with the following changes for the separate-DB approach: - Domain model: ResourceTableQuery, ResourceTableResult, ResourceTableRow, ResourceTableTab, ResourceTabsRequest, ResourceColumnInfo, ResourceColumnFilter, ResourceFacetOption - ClickHouse mapper + repository (queries resource_data_unified view) - ResourceTableController with two POST endpoints + security interceptor - GetResourceTableDataUseCase / GetResourceTableTabsUseCase - ClickhouseJsonMapTypeHandler for METADATA column - Test schema includes resource_data table + resource_data_unified view (simple alias) - Test data with sample/patient/study resource rows MySQL migration.sql and cgds.sql are NOT modified — this feature uses a separate ClickHouse database with the resource_data_unified view. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Introduces a separate database approach (cbioportal_ext) to isolate the resource-table feature from production schema changes: - SecondaryClickhouseConfig: creates DataSource + SqlSessionFactory from spring.clickhouse.secondary.* properties - ResourceMapperFallbackConfig: registers resource mapper on primary datasource when secondary is not configured - ClickhouseMyBatisConfig: explicitly lists non-resource packages to avoid duplicate mapper registration - setup_cbioportal_ext.sql: creates database, resource_data table, resource_data_unified view (cross-DB UNION ALL), and cross-DB views for resource_definition and cancer_study - migrate_resource_data.sql: future backfill script - application.properties.EXAMPLE: documents secondary config - Test schema: adds resource_data_unified view (simple alias) The mapper queries resource_data_unified which transparently serves both new imports AND legacy data from the main cbioportal database. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dippindots
changed the title
dippindots
force-pushed
the
resource-table-v2
branch
from
f9ec19a to
4a81be1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR