error in parsing records before adding ECH data to domains

[ishanjain28]

The bug

This bug happens when ECH is enabled. Caddy downloads existing records, tries to parse them and then add ECH data to them. It fails at the step to parse the domain and does not add any thing to the domain. From the logs, It looks like it encountered error, didn't do any thing and at the end incorrectly printed a message that says that every thing went well!

Steps to repro

1. Use the config on this page, https://caddy.community/t/caddy-2-10-continues-to-fetch-individual-certificates-instead-of-a-wildcard/31695
2. Start caddy with dns-cloudflare
3. Done

How it should work

It should add the ECH data. If it fails to add the ECH data, it should not include that domain in the list of domains it added the data to successfully at the end.

Logs

Aug 02 17:04:18 delbgp caddy[1514854]: {"level":"error","ts":1754134458.3991208,"logger":"tls","msg":"unable to get existing DNS records to publish ECH data to HTTPS DNS record","domain":"auth.ishanjain.me","error":"parsing Cloudflare DNS record {ID:5b2b40d2c496eace5e9b242b3e4b7ede Type:SRV Name:_autodiscover._tcp.ishanjain.me Content:1 443 autodiscover.fastmail.com Priority:0 Proxiable:false Proxied:false TTL:1 Locked:false ZoneID: ZoneName: CreatedOn:2025-05-12 20:50:27.942928 +0000 UTC ModifiedOn:2025-05-12 20:50:27.942928 +0000 UTC Data:{LatDegrees:0 LatMinutes:0 LatSeconds:0 LatDirection: LongDegrees:0 LongMinutes:0 LongSeconds:0 LongDirection: Altitude:0 Size:0 PrecisionHorz:0 PrecisionVert:0 Service: Proto: Name: Priority:0 Weight:1 Port:443 Target:autodiscover.fastmail.com Value: Tag: Flags:0 Protocol:0 Algorithm:0 KeyTag:0 DigestType:0 Usage:0 Selector:0 MatchingType:0 Content:} Meta:0xc00030c600}: name _autodiscover._tcp does not contain enough fields; expected format: '_service._proto.name'"}
Aug 02 17:04:19 delbgp caddy[1514854]: {"level":"error","ts":1754134459.7151415,"logger":"tls","msg":"unable to get existing DNS records to publish ECH data to HTTPS DNS record","domain":"pvepc.home.ishanjain.me","error":"parsing Cloudflare DNS record {ID:5b2b40d2c496eace5e9b242b3e4b7ede Type:SRV Name:_autodiscover._tcp.ishanjain.me Content:1 443 autodiscover.fastmail.com Priority:0 Proxiable:false Proxied:false TTL:1 Locked:false ZoneID: ZoneName: CreatedOn:2025-05-12 20:50:27.942928 +0000 UTC ModifiedOn:2025-05-12 20:50:27.942928 +0000 UTC Data:{LatDegrees:0 LatMinutes:0 LatSeconds:0 LatDirection: LongDegrees:0 LongMinutes:0 LongSeconds:0 LongDirection: Altitude:0 Size:0 PrecisionHorz:0 PrecisionVert:0 Service: Proto: Name: Priority:0 Weight:1 Port:443 Target:autodiscover.fastmail.com Value: Tag: Flags:0 Protocol:0 Algorithm:0 KeyTag:0 DigestType:0 Usage:0 Selector:0 MatchingType:0 Content:} Meta:0xc00042f4e0}: name _autodiscover._tcp does not contain enough fields; expected format: '_service._proto.name'"}
Aug 02 17:04:20 delbgp caddy[1514854]: {"level":"error","ts":1754134460.633859,"logger":"tls","msg":"unable to get existing DNS records to publish ECH data to HTTPS DNS record","domain":"rss.ishanjain.me","error":"parsing Cloudflare DNS record {ID:5b2b40d2c496eace5e9b242b3e4b7ede Type:SRV Name:_autodiscover._tcp.ishanjain.me Content:1 443 autodiscover.fastmail.com Priority:0 Proxiable:false Proxied:false TTL:1 Locked:false ZoneID: ZoneName: CreatedOn:2025-05-12 20:50:27.942928 +0000 UTC ModifiedOn:2025-05-12 20:50:27.942928 +0000 UTC Data:{LatDegrees:0 LatMinutes:0 LatSeconds:0 LatDirection: LongDegrees:0 LongMinutes:0 LongSeconds:0 LongDirection: Altitude:0 Size:0 PrecisionHorz:0 PrecisionVert:0 Service: Proto: Name: Priority:0 Weight:1 Port:443 Target:autodiscover.fastmail.com Value: Tag: Flags:0 Protocol:0 Algorithm:0 KeyTag:0 DigestType:0 Usage:0 Selector:0 MatchingType:0 Content:} Meta:0xc00045cfe0}: name _autodiscover._tcp does not contain enough fields; expected format: '_service._proto.name'"}
Aug 02 17:04:21 delbgp caddy[1514854]: {"level":"error","ts":1754134461.4498823,"logger":"tls","msg":"unable to get existing DNS records to publish ECH data to HTTPS DNS record","domain":"pve.home.ishanjain.me","error":"parsing Cloudflare DNS record {ID:5b2b40d2c496eace5e9b242b3e4b7ede Type:SRV Name:_autodiscover._tcp.ishanjain.me Content:1 443 autodiscover.fastmail.com Priority:0 Proxiable:false Proxied:false TTL:1 Locked:false ZoneID: ZoneName: CreatedOn:2025-05-12 20:50:27.942928 +0000 UTC ModifiedOn:2025-05-12 20:50:27.942928 +0000 UTC Data:{LatDegrees:0 LatMinutes:0 LatSeconds:0 LatDirection: LongDegrees:0 LongMinutes:0 LongSeconds:0 LongDirection: Altitude:0 Size:0 PrecisionHorz:0 PrecisionVert:0 Service: Proto: Name: Priority:0 Weight:1 Port:443 Target:autodiscover.fastmail.com Value: Tag: Flags:0 Protocol:0 Algorithm:0 KeyTag:0 DigestType:0 Usage:0 Selector:0 MatchingType:0 Content:} Meta:0xc000448ac0}: name _autodiscover._tcp does not contain enough fields; expected format: '_service._proto.name'"}
Aug 02 17:04:22 delbgp caddy[1514854]: {"level":"error","ts":1754134462.2435365,"logger":"tls","msg":"unable to get existing DNS records to publish ECH data to HTTPS DNS record","domain":"cups.home.ishanjain.me","error":"parsing Cloudflare DNS record {ID:5b2b40d2c496eace5e9b242b3e4b7ede Type:SRV Name:_autodiscover._tcp.ishanjain.me Content:1 443 autodiscover.fastmail.com Priority:0 Proxiable:false Proxied:false TTL:1 Locked:false ZoneID: ZoneName: CreatedOn:2025-05-12 20:50:27.942928 +0000 UTC ModifiedOn:2025-05-12 20:50:27.942928 +0000 UTC Data:{LatDegrees:0 LatMinutes:0 LatSeconds:0 LatDirection: LongDegrees:0 LongMinutes:0 LongSeconds:0 LongDirection: Altitude:0 Size:0 PrecisionHorz:0 PrecisionVert:0 Service: Proto: Name: Priority:0 Weight:1 Port:443 Target:autodiscover.fastmail.com Value: Tag: Flags:0 Protocol:0 Algorithm:0 KeyTag:0 DigestType:0 Usage:0 Selector:0 MatchingType:0 Content:} Meta:0xc000449ee0}: name _autodiscover._tcp does not contain enough fields; expected format: '_service._proto.name'"}
Aug 02 17:04:23 delbgp caddy[1514854]: {"level":"error","ts":1754134463.1128407,"logger":"tls","msg":"unable to get existing DNS records to publish ECH data to HTTPS DNS record","domain":"request.ishanjain.me","error":"parsing Cloudflare DNS record {ID:5b2b40d2c496eace5e9b242b3e4b7ede Type:SRV Name:_autodiscover._tcp.ishanjain.me Content:1 443 autodiscover.fastmail.com Priority:0 Proxiable:false Proxied:false TTL:1 Locked:false ZoneID: ZoneName: CreatedOn:2025-05-12 20:50:27.942928 +0000 UTC ModifiedOn:2025-05-12 20:50:27.942928 +0000 UTC Data:{LatDegrees:0 LatMinutes:0 LatSeconds:0 LatDirection: LongDegrees:0 LongMinutes:0 LongSeconds:0 LongDirection: Altitude:0 Size:0 PrecisionHorz:0 PrecisionVert:0 Service: Proto: Name: Priority:0 Weight:1 Port:443 Target:autodiscover.fastmail.com Value: Tag: Flags:0 Protocol:0 Algorithm:0 KeyTag:0 DigestType:0 Usage:0 Selector:0 MatchingType:0 Content:} Meta:0xc00030db60}: name _autodiscover._tcp does not contain enough fields; expected format: '_service._proto.name'"}
Aug 02 17:04:23 delbgp caddy[1514854]: {"level":"info","ts":1754134463.1130419,"logger":"tls","msg":"published ECH configuration list","domains":["6.ishanjain.me","dns.ishan.pw","change.ishanjain.me","dash.ishanjain.me","qbit.ishanjain.me","pg.home.ishanjain.me","influx.home.ishanjain.me","strava.ishanjain.me","ha.home.ishanjain.me","pdf.ishanjain.me","ldap.ishanjain.me","dl.ishanjain.me","jellyfin.ishanjain.me","k1.home.ishanjain.me","*.dns.ishan.pw","pvenas.home.ishanjain.me","4.ishanjain.me","znc.home.ishanjain.me","irc.ishanjain.me","vault.ishanjain.me","nvr.home.ishanjain.me","a.ishanjain.me","status.ishanjain.me","omada.home.ishanjain.me","money.ishanjain.me","git.ishanjain.me","t.ishanjain.me","auth.ishanjain.me","pvepc.home.ishanjain.me","rss.ishanjain.me","pve.home.ishanjain.me","cups.home.ishanjain.me","request.ishanjain.me"],"config_ids":[215]}

[mholt]

The parsing errors ("name does not contain enough fields") should already be fixed in: libdns/libdns@8fedb4f -- to go out with the next release, I suppose.

I agree the logs are confusing. It's just a little tricky since PublishECHConfigList() iterates all the inner names and does correctly log an error with any one given name, but we don't want to terminate publication just if one name fails, so we log and continue, and ultimately return a nil error so that we don't break the process for those names which did succeed.

We could probably improve this by returning the list of names that ECH configs were published for (i.e. a subset of the input innerNames, or the whole slice if all succeeded), and then log/proceed accordingly.

[ishanjain28]

We could probably improve this by returning the list of names that ECH configs were published for (i.e. a subset of the input innerNames, or the whole slice if all succeeded), and then log/proceed accordingly.

Yes, this will be much better! I suppose we can keep this issue open until the logs are refactored to better indicate the ECH update results

[mholt]

I have pushed a commit that improves logging to make it a little more accurate.