Skip to content

reverseproxy: Add handle_response blocks to reverse_proxy (#3710) #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mholt merged 9 commits into from
May 2, 2021
Merged

reverseproxy: Add handle_response blocks to reverse_proxy (#3710) #4021

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f58efda
reverseproxy: Add `handle_response` blocks to `reverse_proxy` (#3710)
maxatome Sep 6, 2020
f24b67d
reverseproxy: complete handle_response test
maxatome Sep 19, 2020
5664799
reverseproxy: Change handle_response matchers to use named matchers
francislavoie Feb 16, 2021
a59ea1c
fastcgi: Remove obsolete TODO
francislavoie Feb 16, 2021
696c75a
reverseproxy: Fix support for "4xx" type status codes
francislavoie Feb 18, 2021
677ec82
Apply suggestions from code review
francislavoie Apr 29, 2021
599709d
caddyhttp: Reorganize response matchers
francislavoie Apr 29, 2021
f8768c8
reverseproxy: Reintroduce caddyfile.Unmarshaler
francislavoie May 1, 2021
14eb708
reverseproxy: Add comment mentioning Finalize should be called
francislavoie May 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
  • Loading branch information
@francislavoie @mholt
francislavoie and mholt committed May 2, 2021
commit 677ec82898c40ed32b623af44e017d798d406d22
4 changes: 2 additions & 2 deletions modules/caddyhttp/reverseproxy/caddyfile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func (h *Handler) ParseCaddyfileReverseProxy(helper httpcaddyfile.Helper) error

// collect the response matchers defined as subdirectives prefixed with "@"
// for use with "handle_response" blocks
responseMatchers := map[string]caddyhttp.ResponseMatcher{}
responseMatchers := make(map[string]caddyhttp.ResponseMatcher)

// TODO: the logic in this function is kind of sensitive, we need
// to write tests before making any more changes to it
Expand Down Expand Up @@ -1008,7 +1008,7 @@ func (h *HTTPTransport) UnmarshalCaddyfile(d *caddyfile.Dispenser) error {
//
// @name [header <field> [<value>]] | [status <code...>]
//
func (h *Handler) parseNamedResponseMatcher(d *caddyfile.Dispenser, matchers map[string]caddyhttp.ResponseMatcher) error {
func (Handler) parseNamedResponseMatcher(d *caddyfile.Dispenser, matchers map[string]caddyhttp.ResponseMatcher) error {
for d.Next() {
definitionName := d.Val()

Expand Down