Skip to content

upgrade: inherit the permissions of the original executable #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mholt merged 1 commit into from
May 11, 2021
Merged

upgrade: inherit the permissions of the original executable #4160

mholt merged 1 commit into from
May 11, 2021

Conversation

@mohammed90
Copy link
Member

@mohammed90 mohammed90 commented May 11, 2021

Closes #4158

@mohammed90 mohammed90 added this to the v2.4.1 milestone May 11, 2021
@mohammed90 mohammed90 requested a review from mholt May 11, 2021 22:08
mholt
mholt approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thanks!

@mholt mholt merged commit 2aefe15 into master May 11, 2021
@mohammed90 mohammed90 deleted the inherit-permissions branch May 11, 2021 22:12
Antman2023 pushed a commit to Antman2023/caddy that referenced this pull request May 17, 2021
@mohammed90
cmd: upgrade: inherit the permissions of the original executable (cad…
eba62e3 
…dyserver#4160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mholt mholt mholt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.4.1

Development

Successfully merging this pull request may close these issues.

"caddy upgrade" sets wrong permissions

2 participants

@mohammed90 @mholt