intercept: use already buffered response if possible when intercepting #7028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dunglas Is this something you'd like to take a look at? You're probably busy getting ready for the big API Platform Conference -- so no rush, but maybe afterward I'm curious to get your thoughts! |
| } | ||
|
|
||
| // no new response body and there is some in the original response | ||
| // TODO: what if the new response doesn't have a body by design? |
Member
There was a problem hiding this comment.
To answer this TODO, then if there's no body when it gets here, it just returns nil, right? That seems perfectly fine, same behaviour as if there were a body with no error, basically, unless something up the chain expects something to be copying, but that shouldn't be the case.
francislavoie
approved these changes
Oct 21, 2025
Member
francislavoie
left a comment
francislavoie
left a comment
There was a problem hiding this comment.
I think this makes sense to me.
francislavoie
force-pushed
the
intercept-dup-headers
branch
from
3e5d1af to
64b33c8
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 6992.