httpcaddyfile: Map default_bind to BindHost in globalACMEDefaults#7278
Merged
mholt merged 6 commits intocaddyserver:masterfrom Oct 6, 2025
Monviech:default_bind_tlsapp
Merged
httpcaddyfile: Map default_bind to BindHost in globalACMEDefaults#7278mholt merged 6 commits intocaddyserver:masterfrom Monviech:default_bind_tlsapp
mholt merged 6 commits intocaddyserver:masterfrom
Monviech:default_bind_tlsapp
Conversation
mholt
reviewed
Oct 3, 2025
mholt
approved these changes
Oct 6, 2025
Member
mholt
left a comment
There was a problem hiding this comment.
Nice, thanks for the PR! We'll give it a try. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7210
This attempts to fix issues with
default_bindnot being used for the tls automation policies.In my tests with a local caddy build, I do not see the behavior described in the issue anymore.
Caddyfile for testing:
The generated json, in which we can see that
challengesis now populated with::1(first address from default_bind):Assistance Disclosure
I have used ChatGPT5 Thinking to generate the code, I have authored and tested the result in a local caddy build.
I have written the code comment myself.