Skip to content

Add support for Xcode 11.4 beta 3 #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2020
Merged

Add support for Xcode 11.4 beta 3 #377

merged 5 commits into from
Mar 20, 2020

Conversation

@sergey-plevako-badoo
Copy link
Contributor

@sergey-plevako-badoo sergey-plevako-badoo commented Mar 16, 2020 •
edited by jmoody
Loading

  1. Updated the PrivateHeaders from Xcode Version 11.4 beta 3 (11N132i)
  2. Applied a patch to FBFailureProofTestCase setUp method from the Appium WebDriverAgent repo since internalImplementation has been deprecated in the Xcode 11.4

@sergey-plevako-badoo
Copy link
Contributor Author

sergey-plevako-badoo commented Mar 16, 2020 •
edited by jmoody
Loading

Another thing I have noticed is that the integration tests are running only when the simulator has already been Booted.

There is an error with booting the simulator when I run tests for the Springboard Alerts:
be cucumber -t @reset_device

Could not install app on simulator:

    command: xcrun simctl install D7C03840-317D-48B9-9696-6B7578F33515 /Users/sergeyplevako/Documents/Work/DeviceAgent.iOS/Products/app/TestApp/TestApp.app
  simulator: #<Simulator: iPhone 11 (13.4) D7C03840-317D-48B9-9696-6B7578F33515 x86_64>
        app: #<APP sh.calaba.TestApp 1584392418 / 1.0 /Users/sergeyplevako/Documents/Work/DeviceAgent.iOS/Products/app/TestApp/TestApp.app>

  An error was encountered processing the command (domain=com.apple.CoreSimulator.SimError, code=165):
  Unable to lookup in current state: Shutdown

  This usually means your CoreSimulator processes need to be restarted.

  You can restart the CoreSimulator processes with this command:

  $ bundle exec run-loop simctl manage-processes

   (RuntimeError)
  ./features/support/01_launch.rb:151:in `Before'

@jmoody jmoody changed the title Add support for xCode 11.4 beta 3 Add support for Xcode 11.4 beta 3 Mar 17, 2020
@jmoody
Copy link
Contributor

jmoody commented Mar 18, 2020

Another thing I have noticed is that the integration tests are running only when the simulator has already been Booted.

Is this always reproducible? I wonder if the behavior has changed completely in Xcode 11.4.

@jmoody
Copy link
Contributor

jmoody commented Mar 18, 2020

Updated the PrivateHeaders from Xcode Version 11.4 beta 3 (11N132i)

Did you run bin/class-dump/dump.rb?

jmoody
jmoody suggested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@jmoody jmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions and some minor changes.

Thanks!

DeviceAgent/FBFailureProofTestCase.h Outdated

#import <Foundation/Foundation.h>
#import <XCTest/XCTestCase.h>
#import "XCTestCase.h"
Copy link
Contributor

@jmoody jmoody Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary?

Copy link
Contributor Author

@sergey-plevako-badoo sergey-plevako-badoo Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted in 3a187f1

Server/Application/Application.h Outdated
#import <Foundation/Foundation.h>
#import <UIKit/UIApplication.h>
#import "XCTest+CBXAdditions.h"
#import "CBX-XCTest-Umbrella.h"
Copy link
Contributor

@jmoody jmoody Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor Author

@sergey-plevako-badoo sergey-plevako-badoo Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted in 3a187f1

@sergey-plevako-badoo
Copy link
Contributor Author

sergey-plevako-badoo commented Mar 19, 2020

Updated the PrivateHeaders from Xcode Version 11.4 beta 3 (11N132i)

Did you run bin/class-dump/dump.rb?

Yes, I did

jmoody
jmoody approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@jmoody jmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

@jmoody jmoody merged commit fa22648 into calabash:develop Mar 20, 2020
@JoeSSS JoeSSS mentioned this pull request Apr 8, 2020
Merged
@jmoody jmoody mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jmoody jmoody jmoody approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sergey-plevako-badoo @jmoody