Skip to content

Conversation

@agileseph
Copy link

@agileseph agileseph commented Jun 4, 2020

"DDLogDebug(@"Application %@ is not running", application.identifier);" causes 2 issues:

  1. Unclear error message "Application (null) is not running" in case user call session_delete 2 times in a row
  2. driver loses visibility and return empty hash stub in case session_delete called 2 times in a row and then start any app. It looks like due to implicit assertion issue: "DeviceAgent-Runner[13550:427853] 2020-06-04 13:21:00.285 DEBUG RoutingHTTPServer:225 | DELETE /1.0/session
    t = 48.42s Find the Application 'com.my.app.dev'
    t = 48.43s Collecting extra data to assist test failure triage
    t = 48.54s Assertion Failure: Application.m:101: Failed to get matching snapshot: Application com.my.app.dev is not running""

Fix is simple: use bundleId to read property directly.

@jmoody jmoody merged commit b04a389 into calabash:develop Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants