Hotfix: Embed - Fix issue in accessing sessionStorage in certain scenarios #3851

hariombalhara · 2022-08-15T03:38:44Z

Chrome in incognito mode blocks access to sessionStorage in cross-domain scenario. Even reading sessionStorage throws error.

Fixes #2618

What does this PR do?

Fixes # (issue)

Environment: Production

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Run embed-core dev server and then open http://yoogle.com:3100/embed/?only=ns:default#cal-booking-place-default-iframe(. yoogle.com always refer to localhost. This is a way to similar cross-domain behaviour on local). At this point embed won't work and there would be errors in console. This change should fix the issue.

Checklist

I haven't checked if new and existing unit tests pass locally with my changes

vercel · 2022-08-15T03:38:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
cal	❌ Failed (Inspect)		Aug 16, 2022 at 4:23AM (UTC)

1 Ignored Deployment

Name	Status	Preview	Updated
swagger	⬜️ Ignored (Inspect)		Aug 16, 2022 at 4:23AM (UTC)

… modes in various browsers

emrysal · 2022-08-15T08:52:42Z

Is there a specific reason for using try {} catch {} instead of
typeof window.localStorage !== "undefined" or typeof window.localStorage?.getItem() === "function" (both untested pseudocode, but you get the gist)

hariombalhara · 2022-08-15T12:58:49Z

@emrysal Yeah, Chrome is very strict. You are not even allowed to read localStorage/sessionStorage properties in cross-domain incognito mode.

zomars

Loving the eslint rule approach. Nice work @hariombalhara

zomars · 2022-08-15T19:37:10Z

@hariombalhara should we fallback to using cookies or is that restricted as well?

…cess' into fix/embed-crossdomain-storage-access

hariombalhara · 2022-08-16T04:13:19Z

@zomars Nope, cookies are also not available. Though it fails silently, like there is no problem.

* Close.com App (#3709) * WIP close.com app * Removing leaked dev key (now invalid) * Misspelled env variable * Making progress still WIP * Progress + tests * Final touches * More unit tests * Finished up tests * Merge main * Removing unneeded stuff + submodules * Removing static props, fields fix * Removing unneeded stuff p2 * Commenting * Standarizing APIs * Zodifying Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: zomars <[email protected]> * fix: padding of kBarTrigger (#3846) * fixes issue with variables not working (#3859) Co-authored-by: CarinaWolli <[email protected]> * fix: remove redundant AND (#3833) Co-authored-by: hussamkhatib <[email protected]> * Hotfix: Embed - Fix issue in accessing sessionStorage in certain scenarios (#3851) * Fixes issue when sessionStorage is not accessible in privacy focussed modes in various browsers * Fix eslint errors Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fixed iframe in lark suite, added lark contact info (#3866) * fixed iframe in lark suite, added lark contact info * Update _metadata.ts * Update Railway Template (#3862) * Update Railway Template * Update URL Co-authored-by: Peer Richelsen <[email protected]> * New Crowdin translations by Github Action (#3857) Co-authored-by: Crowdin Bot <[email protected]> * Attempt at redirect to 404 (#3877) * Attempt at redirect to 404 404 should be able to handle the traffic no problem - better ideas welcome. Just a temp fix I imagine; we're not going to want to keep this nor can we expect the User-Agent to continue identifying the traffic source. * Update next.config.js Co-authored-by: zomars <[email protected]> * hotfix dynamic issue (#3864) * Hotfix/dos mitigation attempt error configuration (#3879) * Fixes 'Task timed out after 60.03 seconds' * DDoS rewrite fixes Co-authored-by: zomars <[email protected]> * Fix desktop app link (#3883) * fixed 404 logo on cal video (#3885) * Update all Yarn dependencies (2022-07-29) (#3599) * Update all Yarn dependencies (2022-07-29) * Adds syncpack config * Fixes mismatches * Update yarn.lock * RRule fixes * Locking dayjs to fix build * Type fixes * Fixes mismatches * Submodule sync * Update yarn.lock * Update event.ts * Conflict fixes * Fixes prisma warnings * Liting * Upgrade next, zod * Prevents articfact overwriting * Yarn fixes * Jest fixes * Submodule sync * Formatting * Submodule sync * Adds provider for react-tooltip * Removed dotenv-cli * Readds dotenv-cli * Skips getSchedule tests Until prisma is mocked properly * Fixes * Revert prisma seed script * E2E fixes * test * Removed deprecated req.page in middleware * Make tests stable * Unskip getSchedule tests * fixed 404 logo on cal video (#3885) * Removed PW aliases as aren't needed anymore Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: zomars <[email protected]> Co-authored-by: Hariom Balhara <[email protected]> Co-authored-by: Alex van Andel <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> * Submodule sync * temporally removed missing calendar badge on event-types (#3889) * New Crowdin translations by Github Action (#3878) Co-authored-by: Crowdin Bot <[email protected]> * use default cursor on desktop (#3876) * New Crowdin translations by Github Action (#3890) Co-authored-by: Crowdin Bot <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> * NEXTAUTH_DOMAIN isn't used * Sync submodules * New Crowdin translations by Github Action (#3897) Co-authored-by: Crowdin Bot <[email protected]> * adjust react version * Revert "adjust react version" This reverts commit 6e161da. * cancel booking new design added (#3660) * feat: cancel booking new design added * style: add space-y in button * style: ui fixed for recurring booking * fix: scroll in recurring event and use translation * style: text 2xl instead of text-[24px] * fix: typo, spacing * fix: replaced multiple h2 tags with div * fix: padding and Icon name * Revert " cancel booking new design added" (#3922) This reverts commit a06c564. * New Crowdin translations by Github Action (#3909) Co-authored-by: Crowdin Bot <[email protected]> * New Crowdin translations by Github Action (#3924) Co-authored-by: Crowdin Bot <[email protected]> * New Crowdin translations by Github Action (#3926) Co-authored-by: Crowdin Bot <[email protected]> * fix/auto-connect-calendar-3582 (#3891) * Added alert when there isn't default calendar connected * Add default calendar externalId to select placeholder * Fix typos * Fixes prisma import Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: zomars <[email protected]> * redesigned cancel page to new design (#3923) Co-authored-by: Alex van Andel <[email protected]> * New Crowdin translations by Github Action (#3927) Co-authored-by: Crowdin Bot <[email protected]> * New Crowdin translations by Github Action (#3929) Co-authored-by: Crowdin Bot <[email protected]> * Design issues on success page in some languages (#3900) Co-authored-by: gitstart <[email protected]> Co-authored-by: Nitesh Singh <[email protected]> Co-authored-by: Júlio Piubello da Silva Cabral <[email protected]> Co-authored-by: Matheus Muniz <[email protected]> Co-authored-by: Matheus Benini <[email protected]> Co-authored-by: Grace Nshokano <[email protected]> Co-authored-by: Matheus Muniz <[email protected]> Co-authored-by: gitstart <[email protected]> Co-authored-by: Murilo Amaral <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> * fix: developer docs url (#3914) * fix: developer docs url added * chore : remove / * chore : import url Co-authored-by: Zach Waterfield <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> * Fixes collective availability for teams with overlapping day timezones (#3898) * WIP * Fix for team availability with time offsets * Prevent empty schedule from opening up everything * When no utcOffset or timeZone's are given, default to 0 utcOffset (UTC) * timeZone should not be part of getUserAvailability * Prevents {days:[X],startTime:0,endTime:0} error entry * Added getAggregateWorkingHours() (#3913) * Added test for getAggregateWorkingHours * Timezone isn't used here anymore * fix: developer docs url (#3914) * fix: developer docs url added * chore : remove / * chore : import url Co-authored-by: Zach Waterfield <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> * Test fixes * Reinstate prisma (generate only) and few comments * Test fixes * Skipping getSchedule again * Added await to expect() as it involves async logic causing the promise to timeout * Test cleanup * Update jest.config.ts Co-authored-by: Alan <[email protected]> Co-authored-by: Alex van Andel <[email protected]> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Zach Waterfield <[email protected]> Co-authored-by: Peer Richelsen <[email protected]> * v1.9.1 Co-authored-by: Leo Giovanetti <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: zomars <[email protected]> Co-authored-by: Udit Takkar <[email protected]> Co-authored-by: Carina Wollendorfer <[email protected]> Co-authored-by: CarinaWolli <[email protected]> Co-authored-by: mohammed hussam <[email protected]> Co-authored-by: hussamkhatib <[email protected]> Co-authored-by: Hariom Balhara <[email protected]> Co-authored-by: Jake Cooper <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <[email protected]> Co-authored-by: Alex van Andel <[email protected]> Co-authored-by: Syed Ali Shahbaz <[email protected]> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Julian Benegas <[email protected]> Co-authored-by: alannnc <[email protected]> Co-authored-by: GitStart <[email protected]> Co-authored-by: gitstart <[email protected]> Co-authored-by: Nitesh Singh <[email protected]> Co-authored-by: Júlio Piubello da Silva Cabral <[email protected]> Co-authored-by: Matheus Muniz <[email protected]> Co-authored-by: Matheus Benini <[email protected]> Co-authored-by: Grace Nshokano <[email protected]> Co-authored-by: Matheus Muniz <[email protected]> Co-authored-by: gitstart <[email protected]> Co-authored-by: Murilo Amaral <[email protected]> Co-authored-by: Zach Waterfield <[email protected]>

hariombalhara changed the title ~~Fixes issue when sessionStorage is not accessible in privacy focussed…~~ Hotfix: Embed - Fix issue in accessing sessionStorage in certain scenarios Aug 15, 2022

hariombalhara force-pushed the fix/embed-crossdomain-storage-access branch from 203b246 to 65cd9fc Compare August 15, 2022 03:41

vercel bot had a problem deploying to Preview – cal August 15, 2022 03:41 Failure

hariombalhara force-pushed the fix/embed-crossdomain-storage-access branch from 65cd9fc to f393db6 Compare August 15, 2022 03:42

vercel bot had a problem deploying to Preview – cal August 15, 2022 03:43 Failure

hariombalhara added the automerge label Aug 15, 2022

Fixes issue when sessionStorage is not accessible in privacy focussed…

7982bb9

… modes in various browsers

hariombalhara force-pushed the fix/embed-crossdomain-storage-access branch from f393db6 to 7982bb9 Compare August 15, 2022 05:22

hariombalhara added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Aug 15, 2022

Merge branch 'main' into fix/embed-crossdomain-storage-access

5000f13

hariombalhara requested a review from a team August 15, 2022 05:23

vercel bot had a problem deploying to Preview – cal August 15, 2022 05:44 Failure

Merge branch 'main' into fix/embed-crossdomain-storage-access

1d0e04f

vercel bot had a problem deploying to Preview – cal August 15, 2022 16:39 Failure

Merge branch 'main' into fix/embed-crossdomain-storage-access

461fa45

vercel bot had a problem deploying to Preview – cal August 15, 2022 18:17 Failure

Merge branch 'main' into fix/embed-crossdomain-storage-access

62372c6

zomars approved these changes Aug 15, 2022

View reviewed changes

vercel bot had a problem deploying to Preview – cal August 15, 2022 19:32 Failure

Merge branch 'main' into fix/embed-crossdomain-storage-access

9a1f7f3

vercel bot had a problem deploying to Preview – cal August 15, 2022 19:47 Failure

Merge branch 'main' into fix/embed-crossdomain-storage-access

6e2b955

vercel bot had a problem deploying to Preview – cal August 15, 2022 20:07 Failure

kodiakhq bot added 2 commits August 15, 2022 20:20

Merge branch 'main' into fix/embed-crossdomain-storage-access

1334983

Merge branch 'main' into fix/embed-crossdomain-storage-access

efb1802

vercel bot had a problem deploying to Preview – cal August 15, 2022 20:43 Failure

Merge branch 'main' into fix/embed-crossdomain-storage-access

36edf7e

vercel bot had a problem deploying to Preview – cal August 15, 2022 21:01 Failure

kodiakhq bot added 2 commits August 15, 2022 22:33

Merge branch 'main' into fix/embed-crossdomain-storage-access

4748657

Merge branch 'main' into fix/embed-crossdomain-storage-access

df2c307

vercel bot had a problem deploying to Preview – cal August 15, 2022 22:57 Failure

hariombalhara added 2 commits August 16, 2022 09:32

Fix eslint errors

993029e

Merge remote-tracking branch 'origin/fix/embed-crossdomain-storage-ac…

69fcb4b

…cess' into fix/embed-crossdomain-storage-access

hariombalhara force-pushed the fix/embed-crossdomain-storage-access branch from 43f356e to 69fcb4b Compare August 16, 2022 04:05

kodiakhq bot merged commit bc6c9e1 into main Aug 16, 2022

kodiakhq bot deleted the fix/embed-crossdomain-storage-access branch August 16, 2022 04:18

vercel bot had a problem deploying to Preview – cal August 16, 2022 04:24 Failure

joeauyeung mentioned this pull request Aug 16, 2022

2.0 Settings / My Account {View} #3874

Merged

4 tasks

PeerRich added the core area: core, team members only label Jul 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hotfix: Embed - Fix issue in accessing sessionStorage in certain scenarios #3851

Hotfix: Embed - Fix issue in accessing sessionStorage in certain scenarios #3851

Uh oh!

hariombalhara commented Aug 15, 2022 •

edited

Loading

Uh oh!

vercel bot commented Aug 15, 2022 •

edited

Loading

Uh oh!

emrysal commented Aug 15, 2022

Uh oh!

hariombalhara commented Aug 15, 2022 •

edited

Loading

Uh oh!

zomars left a comment

Uh oh!

zomars commented Aug 15, 2022

Uh oh!

hariombalhara commented Aug 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Hotfix: Embed - Fix issue in accessing sessionStorage in certain scenarios #3851

Hotfix: Embed - Fix issue in accessing sessionStorage in certain scenarios #3851

Uh oh!

Conversation

hariombalhara commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Uh oh!

vercel bot commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emrysal commented Aug 15, 2022

Uh oh!

hariombalhara commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

zomars commented Aug 15, 2022

Uh oh!

hariombalhara commented Aug 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hariombalhara commented Aug 15, 2022 •

edited

Loading

vercel bot commented Aug 15, 2022 •

edited

Loading

hariombalhara commented Aug 15, 2022 •

edited

Loading