V1->V2 connect calendar #3961
Merged
V1->V2 connect calendar #3961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
PeerRich
reviewed
Aug 25, 2022
Comment on lines
617
to
633
| {!defaultCalendarConnected && ( | ||
| <Alert | ||
| severity="warning" | ||
| className="mb-4" | ||
| title={<>{t("missing_connected_calendar") as string}</>} | ||
| message={ | ||
| <Trans i18nKey="connect_your_calendar_and_link"> | ||
| You can connect your calendar from | ||
| <a href="/apps/categories/calendar" className="underline"> | ||
| here | ||
| </a> | ||
| . | ||
| </Trans> | ||
| } | ||
| /> | ||
| )} | ||
| {data.eventTypeGroups.map((group, index) => ( |
Member
There was a problem hiding this comment.
this didnt seem to work in the old PR and was reverted, are we sure we wanna keep this?
Contributor
There was a problem hiding this comment.
Just take whats on main and you should be ready to go. I think on main its called as
alannnc
reviewed
Sep 6, 2022
| }, | ||
| }; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
With new component this is not required now.
alannnc
reviewed
Sep 6, 2022
| <Select | ||
| name="primarySelectedCalendar" | ||
| placeholder={!hidePlaceholder ? `${t("select_destination_calendar")}:` : undefined} | ||
| placeholder={ |
Contributor
There was a problem hiding this comment.
This should stay as this change was made on v1 component
alannnc
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#3891
Puts these changes from V1 into V2 components