Skip to content

Conversation

@joeauyeung
Copy link
Contributor

@joeauyeung joeauyeung commented Aug 26, 2022

What does this PR do?

This PR adds the shell component for the settings pages for both desktop and mobile views

Fixes #4098

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Go to a V2 settings page ex. http://localhost:3000/v2/settings/my-account/profile
  • The shell should show other sections of the settings pages
    • Note that only my account and security are the only pages created right now
  • Reduce your window size to small
  • The top bar should be rendered and when clicking on the button the side drawer should appear

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!
Ship it

@zomars zomars merged commit 3a35eb4 into main Sep 6, 2022
@zomars zomars deleted the V2/settings-shell branch September 6, 2022 18:23
zomars added a commit that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/settings - conferencing broken /settings - sidebar ui issues - multiple Settings need a mobile view