Skip to content

Conversation

@CarinaWolli
Copy link
Member

@CarinaWolli CarinaWolli commented Aug 30, 2022

What does this PR do?

This PR adds the V2 design for Workflows.

Fixes #3793
Fixes #3792
Fixes #3791

Loom Video: https://www.loom.com/share/45c9e5a6e9c448ea871eb3dbdab55201

Loom Video Mobile: https://www.loom.com/share/0f455fa3528e475bb71c2a3374cf4638

Environment: Staging(main branch) / Production

How should this be tested?

  • Do similar steps as shown in the loom video

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@sean-brydon
Copy link
Member

First of all this looks Awesome! With help of @Jaibles we found a few UI NITs
CleanShot 2022-08-31 at 10 49 47


Our Label component should fix this issue as it provides the correct amount of spacing - would also tidy up the label styles around the page

and

For the Dialog one we actually support passing in title + description which should provide the correct amount of spacing also. (I hope :D )

Copy link
Member

@ciaranha ciaranha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this @CarinaWolli. I've left some really minor comments in Loom. (Mostly they're design decisions that affect the app overall and where guidance wasn't provided - not workflow specific, so only do what makes sense in this pr from my suggestions.) Thank you 🙏

# Conflicts:
#	packages/ui/v2/core/EmptyScreen.tsx
Copy link
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @CarinaWolli Added some deprecation comments and merging after all checks pass 🙏

@@ -0,0 +1,28 @@
import { GetStaticPaths, GetStaticProps } from "next";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add some deprecation comments to the v1 file


import { CONSOLE_URL } from "@calcom/lib/constants";
import { Icon } from "@calcom/ui/Icon";
import { EmptyScreen } from "@calcom/ui/v2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added deprecation notice

@zomars zomars merged commit eeabb53 into main Aug 31, 2022
@zomars zomars deleted the feat/v2-workflows branch August 31, 2022 19:42
@CarinaWolli CarinaWolli removed the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Aug 31, 2022
@CarinaWolli CarinaWolli mentioned this pull request Sep 1, 2022
1 task
@CarinaWolli
Copy link
Member Author

Great work on this @CarinaWolli. I've left some really minor comments in Loom. (Mostly they're design decisions that affect the app overall and where guidance wasn't provided - not workflow specific, so only do what makes sense in this pr from my suggestions.) Thank you 🙏

Thank you for your feedback @Jaibles 🙏 Feedback is implemented here: #4070

@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2.0 Workflows Empty State {View} 2.0 Workflows / Create new {flow} 2.0 Workflows {View}

9 participants