allow placing calfrc under $XDG_CONFIG_HOME #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- first check if ~/.calfrc exists, if it does use it - otherwise attempt to create $XDG_CONFIG_HOME/calf/ if it does not exist - if the folder now exists use as path $XDG_CONFIG_HOME/calf/calfrc, otherwise fall back to ~/.calfrc
JohannesLorenz
approved these changes
Oct 19, 2023
Collaborator
JohannesLorenz
left a comment
JohannesLorenz
left a comment
There was a problem hiding this comment.
Only 1 question. The rest of the PR is good. In the next days, I will try to run your PR with the new CI to see if it works.
Collaborator
|
Thanks a lot. It passes CI when I copy it to the WIP CI branch, so time to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first check if ~/.calfrc exists, if it does use it
otherwise attempt to create $XDG_CONFIG_HOME/calf/ if it does not exist
if the folder now exists use as path $XDG_CONFIG_HOME/calf/calfrc, otherwise fall back to ~/.calfrc