Skip to content

Conversation

@StrawnSC
Copy link
Collaborator

@StrawnSC StrawnSC commented Jul 8, 2022


Fixes microsoft/azure-container-apps#299
Since log streaming (and ssh) require an active replica (but ACA allows replicas to scale down to zero), we try to ping the container app's FQDN for these commands. If there are networking restrictions, the command fails at that point. This prevents users from log streaming or using ssh. With this fix, we ignore failures when pinging the app (warning the user to ensure there is an alive replica) and allows the ssh/logstream command to resume

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@StrawnSC StrawnSC merged commit 53e83b0 into calvinsID:containerapp-0.3.8 Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant