Skip to content

Fix flake linter #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinsID merged 1 commit into from
Mar 21, 2022
Merged

Fix flake linter #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/containerapp/azext_containerapp/_clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def poll(cmd, request_url, poll_if_status): # pylint: disable=inconsistent-retu

delete_statuses = ["scheduledfordelete", "cancelled"]

if poll_if_status not in delete_statuses: # Catch "not found" errors if polling for delete
if poll_if_status not in delete_statuses: # Catch "not found" errors if polling for delete
raise e


Expand Down Expand Up @@ -144,7 +144,7 @@ def delete(cls, cmd, resource_group_name, name, no_wait=False):
r = send_raw_request(cmd.cli_ctx, "DELETE", request_url)

if no_wait:
return # API doesn't return JSON (it returns no content)
return # API doesn't return JSON (it returns no content)
elif r.status_code in [200, 201, 202, 204]:
url_fmt = "{}/subscriptions/{}/resourceGroups/{}/providers/Microsoft.App/containerApps/{}?api-version={}"
request_url = url_fmt.format(
Expand All @@ -162,7 +162,6 @@ def delete(cls, cmd, resource_group_name, name, no_wait=False):
pass
logger.warning('Containerapp successfully deleted')


@classmethod
def show(cls, cmd, resource_group_name, name):
management_hostname = cmd.cli_ctx.cloud.endpoints.resource_manager
Expand Down