fix: slack connector user can now use mentions without using an ID#6804
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Slack outbound connector’s chat.postMessage request building so that plain-text messages enable Slack’s name-linking behavior, allowing @user / #channel mentions to be automatically linked without requiring explicit IDs.
Changes:
- Set
linkNames=trueonChatPostMessageRequestwhenmessageTypeisplainText.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@johnBgood I've opened a new pull request, #6805, to work on those changes. Once the pull request is ready, I'll request review from you. |
9d9f8b4 to
aa37d1b
Compare
| camunda.endpoints.cors.mappings=/inbound-instances/** | ||
| camunda.client.prefer-rest-over-grpc=false | ||
| camunda.client.rest-address=http://localhost:8088 | ||
| camunda.client.rest-address=http://localhost:8080 |
There was a problem hiding this comment.
this was changed by mistake I guess
There was a problem hiding this comment.
Yes, thanks for fixing. Did change this everytime locally
#6805) Agent-Logs-Url: https://github.com/camunda/connectors/sessions/c0d9223d-df3d-4c96-b6df-b3b580126cf6 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com>
71ded6e to
1429dbe
Compare
mathias-vandaele
left a comment
There was a problem hiding this comment.
Thanks @johnBgood !
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.7
git worktree add -d .worktree/backport-6804-to-stable/8.7 origin/stable/8.7
cd .worktree/backport-6804-to-stable/8.7
git switch --create backport-6804-to-stable/8.7
git cherry-pick -x 09fec0176b7d68c6755ebfa30e54251efe1b8c4f |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.8
git worktree add -d .worktree/backport-6804-to-stable/8.8 origin/stable/8.8
cd .worktree/backport-6804-to-stable/8.8
git switch --create backport-6804-to-stable/8.8
git cherry-pick -x 09fec0176b7d68c6755ebfa30e54251efe1b8c4f |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.6
git worktree add -d .worktree/backport-6804-to-stable/8.6 origin/stable/8.6
cd .worktree/backport-6804-to-stable/8.6
git switch --create backport-6804-to-stable/8.6
git cherry-pick -x 09fec0176b7d68c6755ebfa30e54251efe1b8c4f |
…6804) * fix: slack connector user can now use mentions without using an ID * test: add assertions for linkNames behavior in ChatPostMessageDataTest (#6805) Agent-Logs-Url: https://github.com/camunda/connectors/sessions/c0d9223d-df3d-4c96-b6df-b3b580126cf6 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com> (cherry picked from commit 09fec01)
|
Successfully created backport PR for |
…6804) * fix: slack connector user can now use mentions without using an ID * test: add assertions for linkNames behavior in ChatPostMessageDataTest (#6805) Agent-Logs-Url: https://github.com/camunda/connectors/sessions/c0d9223d-df3d-4c96-b6df-b3b580126cf6 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com> (cherry picked from commit 09fec01)
…6804) * fix: slack connector user can now use mentions without using an ID * test: add assertions for linkNames behavior in ChatPostMessageDataTest (#6805) Agent-Logs-Url: https://github.com/camunda/connectors/sessions/c0d9223d-df3d-4c96-b6df-b3b580126cf6 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com> (cherry picked from commit 09fec01)
…6804) * fix: slack connector user can now use mentions without using an ID * test: add assertions for linkNames behavior in ChatPostMessageDataTest (#6805) Agent-Logs-Url: https://github.com/camunda/connectors/sessions/c0d9223d-df3d-4c96-b6df-b3b580126cf6 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com> (cherry picked from commit 09fec01)
…6804) (#6809) * fix: slack connector user can now use mentions without using an ID * test: add assertions for linkNames behavior in ChatPostMessageDataTest (#6805) Agent-Logs-Url: https://github.com/camunda/connectors/sessions/c0d9223d-df3d-4c96-b6df-b3b580126cf6 --------- (cherry picked from commit 09fec01) Co-authored-by: Jonathan Roques <jonathan.roques@camunda.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com>
…6804) (#6810) * fix: slack connector user can now use mentions without using an ID * test: add assertions for linkNames behavior in ChatPostMessageDataTest (#6805) Agent-Logs-Url: https://github.com/camunda/connectors/sessions/c0d9223d-df3d-4c96-b6df-b3b580126cf6 --------- (cherry picked from commit 09fec01) Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com>
…6804) (#6811) * fix: slack connector user can now use mentions without using an ID * test: add assertions for linkNames behavior in ChatPostMessageDataTest (#6805) Agent-Logs-Url: https://github.com/camunda/connectors/sessions/c0d9223d-df3d-4c96-b6df-b3b580126cf6 --------- (cherry picked from commit 09fec01) Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: johnBgood <1797846+johnBgood@users.noreply.github.com>
|
🎉 This pull request has been included in release Thank you for your contribution! 🚀 |
|
🎉 This pull request has been included in release Thank you for your contribution! 🚀 |
|
🎉 This pull request has been included in release Thank you for your contribution! 🚀 |
|
🎉 This pull request has been included in release Thank you for your contribution! 🚀 |
Description
This pull request introduces a small but important improvement to the way plain text messages are sent via Slack. Specifically, it ensures that user and channel mentions in plain text messages are automatically linked, enhancing the user experience.
linkNamesproperty is now set totruein the Slack API request, so user and channel mentions will be properly linked.Checklist
release, as this branch will be rebased onto main before the next release. Example backport labels:
backport stable/8.8: for changes that should be included in the next 8.8.x release.backport release-8.8.7: for changes that should be included in the specific release 8.8.7, and thisrelease has already been created. The release branch will be merged back into stable/8.8 later, so the change
will be included in future 8.8.x releases as well.