fix(test): remove @Test annotation as @Disabled was not enough in CI,…#6988
Conversation
… still being ran
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize CI for the email connector by effectively removing a flaky integration test that intermittently fails due to GreenMail IMAP handler uncaught exceptions (tracked in #6819).
Changes:
- Prevents execution of
pollingManagerBreaksAndRecoverAfterServerNotRespondingby commenting out its@Testannotation.
| Tracked in: https://github.com/camunda/connectors/issues/6819 | ||
| """) | ||
| @Test | ||
| // @Test |
There was a problem hiding this comment.
Commenting out @Test leaves a @Disabled annotation that no longer has any effect (JUnit only applies it to discovered tests), and the commented-out annotation is easy to miss/accidentally re-enable. Prefer either (a) removing the @Test line entirely and converting the @Disabled(...) block into a regular comment, or (b) keeping @Test and relying on @Disabled(...) so the skip reason remains visible in test reports.
| // @Test | |
| @Test |
|
/backport |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.8
git worktree add -d .worktree/backport-6988-to-stable/8.8 origin/stable/8.8
cd .worktree/backport-6988-to-stable/8.8
git switch --create backport-6988-to-stable/8.8
git cherry-pick -x e276cd3c4cab086b04cf8526a65622df1e7490a0 |
|
Successfully created backport PR for |
|
🎉 This pull request has been included in release Thank you for your contribution! 🚀 |
|
🎉 This pull request has been included in release Thank you for your contribution! 🚀 |
github-actions
Bot
added
the
version:8.10.0-alpha1
This pull request makes a small change to the email connector integration tests by disabling a flaky test that intermittently fails due to issues with the GreenMail IMAP handler.
pollingManagerBreaksAndRecoverAfterServerNotRespondingtest inInboundRecoveringTest.javaby commenting out the@Testannotation, as it intermittently fails and is tracked in issue Fix flaky test: InboundRecoveringTest.pollingManagerBreaksAndRecoverAfterServerNotResponding #6819.