Skip to content

fix(agentic-ai): forward configured env vars for STDIO MCP client transport #7163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maff merged 5 commits into from
May 8, 2026
Merged

fix(agentic-ai): forward configured env vars for STDIO MCP client transport #7163

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5161246
Initial plan
Copilot May 8, 2026
ed477c3
fix(agentic-ai): forward stdio env into MCP server parameters
Copilot May 8, 2026
e954b2f
test(agentic-ai): assert stdio env via built client path
Copilot May 8, 2026
51a51e4
test(agentic-ai): assert stdio command/args/env across configurations
maff May 8, 2026
9cf250c
test(agentic-ai): capture stdio ServerParameters via mockConstruction
maff May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(agentic-ai): assert stdio env via built client path 
Agent-Logs-Url: https://github.com/camunda/connectors/sessions/887c1731-fe31-4eab-b4bf-ce11b1eaee87

Co-authored-by: maff <27403+maff@users.noreply.github.com>
  • Loading branch information
@maff
Copilot and maff authored May 8, 2026
commit e954b2f3416159a448d50e0f61791f5960d52e7c
22 changes: 15 additions & 7 deletions ...a/io/camunda/connector/agenticai/mcp/client/framework/mcpsdk/McpSdkClientFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import io.camunda.connector.http.client.client.jdk.proxy.JdkHttpClientProxyConfigurator;
import io.modelcontextprotocol.client.McpSyncClient;
import io.modelcontextprotocol.client.transport.ServerParameters;
import io.modelcontextprotocol.spec.McpClientTransport;
import java.time.Duration;
import java.util.Arrays;
import java.util.List;
Expand Down Expand Up @@ -107,9 +108,12 @@ void forwardsConfiguredStdioEnvironmentVariablesToServerParameters() {
final var stdioConfig =
new StdioMcpClientTransportConfiguration(
"command", List.of("arg1"), Map.of("MCP_TOKEN", "secret-token"));
final var client =
factory.createClient(
CLIENT_ID, createMcpClientConfiguration(McpClientType.STDIO, stdioConfig, null, null));

final var transport =
ReflectionTestUtils.invokeMethod(factory, "createStdioTransport", stdioConfig);
final var internalClient = (McpSyncClient) ReflectionTestUtils.getField(client, "delegate");
final var transport = extractFieldByType(internalClient, McpClientTransport.class);
final var serverParameters = extractServerParameters(transport);

assertThat(serverParameters.env()).containsEntry("MCP_TOKEN", "secret-token");
Expand Down Expand Up @@ -219,19 +223,23 @@ private static StdioMcpClientTransportConfiguration createStdioMcpClientTranspor
}

private static ServerParameters extractServerParameters(Object transport) {
return Arrays.stream(transport.getClass().getDeclaredFields())
.filter(field -> field.getType().equals(ServerParameters.class))
return extractFieldByType(transport, ServerParameters.class);
}

private static <T> T extractFieldByType(Object source, Class<T> type) {
return Arrays.stream(source.getClass().getDeclaredFields())
.filter(field -> type.isAssignableFrom(field.getType()))
.findFirst()
.map(
field -> {
field.setAccessible(true);
try {
return (ServerParameters) field.get(transport);
return type.cast(field.get(source));
} catch (IllegalAccessException e) {
throw new IllegalStateException("Unable to read ServerParameters field", e);
throw new IllegalStateException("Unable to read %s field".formatted(type), e);
}
})
.orElseThrow(() -> new IllegalStateException("No ServerParameters field found"));
.orElseThrow(() -> new IllegalStateException("No %s field found".formatted(type)));
}

private static StreamableHttpMcpClientTransportConfiguration
Expand Down