Skip to content

Replace std::error::Error with core::error::Error #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2025
Merged

Replace std::error::Error with core::error::Error #192

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9b4e76
Replace std::error::Error with core::error::Error
codebycruz Sep 9, 2025
58be1fe
rs: bump MSRV to 1.81.0
jiegec Sep 22, 2025
b76579e
rs: apply cargo clippy
jiegec Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Replace std::error::Error with core::error::Error 
This was stabilized in Rust 1.81 and was pointed out by the comment
above the impl.
  • Loading branch information
@codebycruz
codebycruz committed Sep 9, 2025
commit d9b4e763718a8707c204ac8132deb5938f9cb3bc
4 changes: 1 addition & 3 deletions capstone-rs/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@ capstone_error_def!(
=> UnsupportedX86Masm = CS_ERR_X86_MASM;
);

// Required until https://github.com/rust-lang/rust/issues/103765 is resolved
#[cfg(feature = "std")]
impl std::error::Error for Error {}
impl core::error::Error for Error {}

pub type CsResult<T> = result::Result<T, Error>;

Expand Down
Loading