feat: update profile #150
feat: update profile #150
Conversation
|
Thank you for following the naming conventions for pull request titles! 🙏 |
Raju-kadel-27
changed the title
| where: { | ||
| status: "ACTIVE", | ||
| id: user.memberId, | ||
| companyId: user.companyId, |
There was a problem hiding this comment.
filtering by companyId is not necessary here.
| FormLabel, | ||
| FormMessage, | ||
| } from "@/components/ui/form"; | ||
| const profileSettingsSchema = z.object({ |
There was a problem hiding this comment.
Move this schema to a dedicated file so that it can be used on the backend as well.
| const [file, setFile] = useState<File | null>(null); | ||
| const fileInputRef = useRef<HTMLInputElement>(null); | ||
|
|
||
| // @ts-expect-error: xxxx |
| resolver: zodResolver(profileSettingsSchema), | ||
| }); | ||
|
|
||
| // @ts-expect-error: xxxx |
| }, | ||
| }); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I think we need to fetch data initially from the server component and pass the profile as prop. useEffect is redundant here.
| } | ||
| }, [memberProfile?.data, form]); | ||
|
|
||
| const handleImageUpload = async ( |
There was a problem hiding this comment.
Remove this unused function.
| const handleFileChange = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
| const files = event.target.files; | ||
|
|
||
| if (files?.[0]) { |
There was a problem hiding this comment.
Extract the file validation logic to a utils.
| const handleRemoveAvatar = () => { | ||
| setFile(null); | ||
| }; | ||
| async function onSubmit(values: z.infer<typeof profileSettingsSchema>) { |
There was a problem hiding this comment.
Changing a profile picture and saving profile information are two different actions like I said the day before. Clicking on save button should only save the profile information.
chetannn
left a comment
chetannn
left a comment
There was a problem hiding this comment.
I have requested for some changes. Awesome work BTW
|
@chetannn I think I fixed the requested changes ?? |
3 participants
PR for issue #139