Skip to content

Conversation

@rbalman
Copy link
Contributor

@rbalman rbalman commented May 22, 2024

I would like to add following minor enhancements for local docker compose setup.

  • Add adminer as the UI based database manager for easier visualization and management of database and tables locally. It can be accessed under port localhost:8080
  • Removing the need of Dockerfile.dev by leveraging the compose.yml file.
    • Specific version of the node(20.10.0) is being used and information is received from the .env file
    • Specific version of the pnpm(9.1.2) is utilized.
  • Minor yaml fixes on minio-client

Screenshots

Local Setup

Local App Setup

@github-actions
Copy link

github-actions bot commented May 22, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@rbalman rbalman changed the title Feat: Improvise the docker compose setup for local development feat: Improvise the docker compose setup for local development May 22, 2024
Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull-request @rbalman , I have made few suggestions, everything else looks great. 🫡

@rbalman
Copy link
Contributor Author

rbalman commented May 22, 2024

@dahal Is the pnpm-lock.yaml file's change valid ? I am unsure of that, It probably changed because I pegged the pnpm version to latest version 9.1.2. Shall I revert and peg the version to 6.x.x or is this okay?

@rbalman rbalman requested a review from dahal May 23, 2024 02:27
@dahal
Copy link
Contributor

dahal commented May 23, 2024

@dahal Is the pnpm-lock.yaml file's change valid ? I am unsure of that, It probably changed because I pegged the pnpm version to latest version 9.1.2. Shall I revert and peg the version to 6.x.x or is this okay?

Yes, that should be fine.

Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting this error

WARN[0000] The "NODE_VERSION" variable is not set. Defaulting to a blank string.

Are we expected to pass NODE_VERSION when we run docker compose up, instead can we set a default somewhere?

Also, lets run pnpm db:studio as well. It could part of the same service app, or a different one called studio.

@rbalman
Copy link
Contributor Author

rbalman commented May 24, 2024

I am getting this error

WARN[0000] The "NODE_VERSION" variable is not set. Defaulting to a blank string.

Do you have NODE_VERSION declared in the .env file? I added it in the new .env.example file.

@rbalman rbalman force-pushed the feat/improvise-docker-compose-setup branch from 6ebca46 to 66aa43c Compare May 24, 2024 22:57
@rbalman
Copy link
Contributor Author

rbalman commented May 24, 2024

I have published my final changes, after our sync @dahal. Below is the latest screenshot of my local setup.

Prisma Studio Application

@rbalman rbalman requested a review from dahal May 24, 2024 23:03
Copy link
Contributor

@dahal dahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for optimizing our developer experience @rbalman

@dahal dahal force-pushed the feat/improvise-docker-compose-setup branch from b19bed5 to 35e82d5 Compare June 4, 2024 07:36
@dahal dahal merged commit 6c1353b into captableinc:main Jun 4, 2024
@rbalman rbalman deleted the feat/improvise-docker-compose-setup branch June 5, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants