-
Notifications
You must be signed in to change notification settings - Fork 155
feat: Improvise the docker compose setup for local development #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improvise the docker compose setup for local development #349
Conversation
|
Thank you for following the naming conventions for pull request titles! 🙏 |
dahal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this pull-request @rbalman , I have made few suggestions, everything else looks great. 🫡
|
@dahal Is the |
Yes, that should be fine. |
dahal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting this error
WARN[0000] The "NODE_VERSION" variable is not set. Defaulting to a blank string.
Are we expected to pass NODE_VERSION when we run docker compose up, instead can we set a default somewhere?
Also, lets run pnpm db:studio as well. It could part of the same service app, or a different one called studio.
Do you have |
6ebca46 to
66aa43c
Compare
|
I have published my final changes, after our sync @dahal. Below is the latest screenshot of my local setup.
|
dahal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for optimizing our developer experience @rbalman
b19bed5 to
35e82d5
Compare


I would like to add following minor enhancements for local docker compose setup.
admineras the UI based database manager for easier visualization and management of database and tables locally. It can be accessed under portlocalhost:8080Dockerfile.devby leveraging the compose.yml file.node(20.10.0) is being used and information is received from the.envfilepnpm(9.1.2) is utilized.minio-clientScreenshots
Local Setup