Skip to content

Resolve unique key issue in showcase and builder tools page #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Resolve unique key issue in showcase and builder tools page #1037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/showcase/ShowcaseCard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const ShowcaseCard = memo((card) => (
<Link href={card.showcase.website}>{card.showcase.title}</Link>
</h4>
{card.showcase.tags.includes("favorite") && (
<Fav svgClass={styles.svgIconFavorite} size="small" />
<Fav className={styles.svgIconFavorite} size="small" />
)}
{card.showcase.getstarted && (
<Link
Expand Down
10 changes: 4 additions & 6 deletions src/pages/showcase/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,11 @@ function ShowcaseFilters() {
<ShowcaseFilterToggle />
</div>
<div className={styles.checkboxList}>
{TagList.map((tag) => {
{TagList.map((tag, i) => {
const { label, description, color } = Tags[tag];
const id = `showcase_checkbox_id_${tag}`;
return (
<>
<div className={styles.checkboxListItem}>
<div key={i} className={styles.checkboxListItem}>
<ShowcaseTooltip
id={id}
text={description}
Expand All @@ -200,7 +199,7 @@ function ShowcaseFilters() {
}}
>
<Fav
svgClass={styles.svgIconFavorite}
className={styles.svgIconFavorite}
size="small"
style={{ display: "grid" }}
/>
Expand All @@ -220,7 +219,6 @@ function ShowcaseFilters() {
/>
</ShowcaseTooltip>
</div>
</>
);
})}
</div>
Expand Down Expand Up @@ -255,7 +253,7 @@ function ShowcaseCards() {
)}
>
<h2 className={styles.ourFavorites}>Our favorites</h2>
<Fav svgClass={styles.svgIconFavorite} size="small" />
<Fav className={styles.svgIconFavorite} size="small" />
<SearchBar />
</div>
<ul className={clsx("container", styles.showcaseList)}>
Expand Down
4 changes: 0 additions & 4 deletions src/pages/showcase/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,6 @@
font-size: 1rem;
}

.svgIconFavorite {
margin-left: 1rem;
}

.ourFavorites {
margin-right: 0.7rem;
}
8 changes: 3 additions & 5 deletions src/pages/tools/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,11 @@ function ShowcaseFilters() {

function filterBy(tags) {
return (<div className={styles.checkboxList}>
{tags.map((tag) => {
{tags.map((tag, i) => {
const { label, description, color } = Tags[tag];
const id = `showcase_checkbox_id_${tag}`;
return (
<>
<div className={styles.checkboxListItem}>
<div key={i} className={styles.checkboxListItem}>
<ShowcaseTooltip
id={id}
text={description}
Expand All @@ -221,7 +220,6 @@ function filterBy(tags) {
/>
</ShowcaseTooltip>
</div>
</>
);
})}
</div>);
Expand Down Expand Up @@ -254,7 +252,7 @@ function ShowcaseCards() {
)}
>
<h2 className={styles.ourFavorites}>Our favorites</h2>
<Fav svgClass={styles.svgIconFavorite} size="small" />
<Fav className={styles.svgIconFavorite} size="small" />
<SearchBar />
</div>
<ul className={clsx("container", styles.showcaseList)}>
Expand Down
4 changes: 0 additions & 4 deletions src/pages/tools/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,6 @@
font-size: 1rem;
}

.svgIconFavorite {
margin-left: 1rem;
}

.ourFavorites {
margin-right: 0.7rem;
}