Skip to content

Add Python Module #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2021
Merged

Add Python Module #220

merged 4 commits into from
Aug 16, 2021

Conversation

@emesik
Copy link
Contributor

@emesik emesik commented Aug 6, 2021

This PR adds Python Module to Builder Tools page. All details are already in the source code.

@rdlrt
Copy link
Collaborator

rdlrt commented Aug 7, 2021 •
edited
Loading

Thanks for the contribution, it seems the codebase being referred has skeleton working model at the moment for work you'll be doing, while it connects to cardano-wallet as backend, which would be custodial or for individual use (if that is the plan , your description should indicate as such - as it defines the target audience).

@emesik
Copy link
Contributor Author

emesik commented Aug 7, 2021

It is already usable module that might be used by developers right away. They are the target audience.

The project was intended to run on private wallets from the very beginning. It's not a public service, although it might be used to build such, as it provides useful tools that offer higher abstraction layer.

@rdlrt
Copy link
Collaborator

rdlrt commented Aug 7, 2021

The project was intended to run on private wallets from the very beginning

Thanks for clarifying, in that case - can I request you to add "using cardano-wallet instance" to description?

Just some background on request : Currently there are a lot of projects trying to incorrectly use libraries they find online against API and end up starting to build public service using wallet backend (incl. some that are not supposed to be custodial). Having that clarity on description helps safeguard any future complains on text on developers.cardano.org.

katomm
katomm requested changes Aug 7, 2021
View reviewed changes
Copy link
Member

@katomm katomm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thank you very much for the contributions.

Please allow me to request two changes:

  • you must not set the "featured" flag yourself.
  • you can not set the "getstarted" flag without having a "get started"-page in the portal. Please see the other builder tools with a get started page in the portal as an example, but we need to make this concept clearer in the future. (i.e. either create a "get started" page or remove the tag and the link to the external get started page)

Thank you.

rdlrt
rdlrt requested changes Aug 8, 2021
View reviewed changes
@emesik emesik requested review from katomm and rdlrt August 8, 2021 08:33
katomm
katomm approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions @emesik!

@katomm katomm merged commit 7092992 into cardano-foundation:staging Aug 16, 2021
Mercurial added a commit that referenced this pull request Aug 23, 2021
@Mercurial @dependabot
@katomm @thegalgos @emesik @cislakk @arivictor @atx-barnes
Merged PRs #176, #163, #220, #240, #246, #244, #245, #249, #256 to ma…
fd4ce3d 
…in (#260)

* Bump color-string from 1.5.4 to 1.6.0

Bumps [color-string](https://github.com/Qix-/color-string) from 1.5.4 to 1.6.0.
- [Release notes](https://github.com/Qix-/color-string/releases)
- [Changelog](https://github.com/Qix-/color-string/blob/master/CHANGELOG.md)
- [Commits](Qix-/color-string@1.5.4...1.6.0)

---
updated-dependencies:
- dependency-name: color-string
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump prismjs from 1.23.0 to 1.24.1

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.23.0 to 1.24.1.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.23.0...v1.24.1)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump path-parse from 1.0.6 to 1.0.7

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add showcase guideline proposed in #176 (#235)

* Added The Galgos NFT project (#163)

* Add Python Module (#220)

* Add Python Module

* Add mention of cardano-wallet backend

* Remove tags

* Remove getstarted link

* fix urls and native token sentence (#240)

* fix: backslash missing from code example (#246)

* removed duplicate for copy command (#244)

* IO Fix (#245)

Co-authored-by: Priyank

* Update get started with developer community (#249)

* august developer spotlight article mercury (#256)

Co-authored-by: Kevin Cislak <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tommy <[email protected]>
Co-authored-by: thegalgos <[email protected]>
Co-authored-by: Michał Sałaban <[email protected]>
Co-authored-by: cislakk <[email protected]>
Co-authored-by: Ari V <[email protected]>
Co-authored-by: Jackson Barnes <[email protected]>
Co-authored-by: Kevin Cislak <[email protected]>
katomm added a commit that referenced this pull request Sep 7, 2021
@katomm @dependabot
Merge PRs #258, #261, #262, #263, #264, #269, and #280 into main (#281)
9030234 
* Bump color-string from 1.5.4 to 1.6.0

Bumps [color-string](https://github.com/Qix-/color-string) from 1.5.4 to 1.6.0.
- [Release notes](https://github.com/Qix-/color-string/releases)
- [Changelog](https://github.com/Qix-/color-string/blob/master/CHANGELOG.md)
- [Commits](Qix-/color-string@1.5.4...1.6.0)

---
updated-dependencies:
- dependency-name: color-string
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump prismjs from 1.23.0 to 1.24.1

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.23.0 to 1.24.1.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.23.0...v1.24.1)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump path-parse from 1.0.6 to 1.0.7

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add showcase guideline proposed in #176 (#235)

* Added The Galgos NFT project (#163)

* Add Python Module (#220)

* Add Python Module

* Add mention of cardano-wallet backend

* Remove tags

* Remove getstarted link

* fix urls and native token sentence (#240)

* fix: backslash missing from code example (#246)

* removed duplicate for copy command (#244)

* IO Fix (#245)

Co-authored-by: Priyank

* Update get started with developer community (#249)

* august developer spotlight article mercury (#256)

Co-authored-by: Kevin Cislak 

* Fix Spelling of Address (#258)

Change "Adress" to "Address"

* Fix spelling of 'metadata' (#261)

Changed "metdata" to "metadata"

* quickfix typo (#262)

* fix grammatical error

* fix some typos and grammar

quickfixes

* fix repetition of 'the' (#263)

* removed unsigned_algorithms (#264)

* Fix typo in portal style guide (#269)

* Update testnet page (Alonzo) (#280)

* Fix testnet faucet iFrame

* Remove Shelley and Mary references, rename Daedalus testnet

* Make the testnet explorer easier to find, update text

* Fix indentations

* Update links

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Clark Alesna 
Co-authored-by: thegalgos 
Co-authored-by: Michał Sałaban 
Co-authored-by: cislakk
Co-authored-by: Ari V 
Co-authored-by: Jackson Barnes 
Co-authored-by: Kevin Cislak 
Co-authored-by: Charles Jenkins 
Co-authored-by: Pedro Moreira 
Co-authored-by: Daniel Koman
Co-authored-by: Bb 
Co-authored-by: Alexander Watanabe 
Co-authored-by: Ben Bowen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdlrt rdlrt rdlrt approved these changes

@katomm katomm katomm approved these changes

+1 more reviewer

@Mercurial Mercurial Mercurial approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emesik @rdlrt @Mercurial @katomm