chapter 4--tree-- question 4 solution added to the bottom #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycedrennan
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Thanks for your contribution! I've left feedback just for educational purposes.
I made some small changes and merged your work here: c35c99b
| #Alternative Recursive Approach | ||
|
|
||
| # Balanced Tree | ||
| class Node(): |
There was a problem hiding this comment.
This class isn't used in the code anywhere and can thus be deleted.
| self.right = right | ||
|
|
||
|
|
||
| def helper(root): |
There was a problem hiding this comment.
This is too generic of a function name. Names should describe what the function does. In this case, _find_height would be a good name.
|
|
||
| return max(leftheight, rightheight) + 1 | ||
|
|
||
| def isBalanced(root): |
There was a problem hiding this comment.
function names in python should use underscore case (is_balanced)
HOD101s
pushed a commit
to HOD101s/CtCI-6th-Edition-Python-1
that referenced
this pull request
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your great work!
I have added my solution which I found easier to understand at the bottom of your code under the
Alternative Recursive Approachcomment! Hope this helps the community and people getting ready for the interviews!