Getting latest next #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) ### Breaking change ```diff -import { componentPropType } from '@material-ui/utils'; +import PropTypes from 'prop-types'; SomeComponent.propTypes = { - component: componentPropType, + component: PropTypes.elementType, } ``` Switched the wording from `Component` to `element type` in the docs. This is more in line with the [flow types](https://github.com/facebook/flow/blob/master/website/en/docs/react/types.md#toc-react-elementtype) and now `prop-types`.
- remove redundant `aria-hidden`, `visibility` is a better alternative Also in this PR: It's not `vibility` or `visiblity`. It's `visibility`.
* [core] Track size via build artifacts * [core] Fix size snapshot failing on ci tmp/ was not created on ci * [ci] Fix size snapshot not being saved * [ci] Decouple size snapshot from test pipeline Use circle ci workspaces to persist build output. attach that workspace in a size_snapshot job. dangerJS will later run in that job and report size changes. An additional persist_size_snapshot will later upload the size-snapshot permanently. CircleCI artifacts are not supposed to be used permanently. Only "around build time". * [ci] Persist snapshot in s3 bucket * [ci] Add dangerfile * [ci] Fix pull requests not being recognized * [ci] Proper dangerJS report * [ci] Silence non existing snapshots * [ci] Print commit range to CI * [ci] Fix violation passed to danger js * [docs] explain scripts folder structure * [ci] Remove debug tasks * [ci] Report even with no changes * [ci] Fix danger js violation if no important change * [ci] Fix no change being considered any change * [ci] Improve review expierence * [core] Remove rollup snapshot createSizeSnapshot script takes care of this * [ci] improve config docs * [ci] Fix emoji in bundle changes details * [ci] cleanup danger async runner * [ci] reintriduce umd smoke test was only removed to speed up CI * [ci] Fix lint errors * [ci] Refactor code - improves code docs - move some generic utils to utils module * [ci] Use +-inf the mark added/removed snapshots * [ci] Fix new bundles being considered as reducing size * [ci] Consider non-existing as zero allows for more useful comparison: - add means current.size abs change, +inf rel change - remove means -prev.size abs change, -100% rel change * [ci] Place change emoji after percent looks "weird" otherwise * [ci] Fix increase being displayed like reduction (triangle down) * [ci] Fix outdated code comments * [ci] Use upercase snakecase for constants * [core] Remove legacy scripts * [ci] Improve destructuring semantics * [ci] Exit with non-zero for any error in danger This will leave a "fail" comment on the PR but it's better than having the build show green. * [scripts] Remove utils in favor of lodash
* [MobileStepper] Remove unused classname in example * Remove other unused classes.mobileStepper
* [ci] Improve table format * [ci] Add lab to size snapshot * [ci] Fix failed workspace persistence Suspected it failed because of to many files. Now persisting a single tarbal * [ci] Fix Module not found in size:snapshot * [ci] Reduce danger noise
* [docs] Update the Team * Update docs/src/pages/discover-more/team/Team.js Co-Authored-By: oliviertassinari <[email protected]> * josh review * Rewording
* Update ExpansionPanelSummary docs * Update ExpansionPanelSummary.js * Update expansion-panel-summary.md * Resolve lint error * Fix typo
* [ExpansionPanel] Prop to customize Collapse * [ExpansionPanel]: Use elementType instead of componentPropType * [ExpansionPanel] Real life test for CustomComponent * [ExpansionPanel] Lint + Prettier * [ExpansionPanel] Update docs * Redundant assertion * Rename CollapseComponent to TransitionComponent * sort alpha
Resolves issue with 3.9.2
* Update ScrollDialog Demo for 4k Add extra content to ScrollDialog demo so that it's scrollable on 4k displays * [docs] Update ScrollDialog Demo for 4k
* [docs] SimpleSelect cleaner hooks * [core] Add eslint-plugin-react-hooks * [docs] Fix broken CircularDeterminate hooks demo * [docs] Fix leaky CircularIntegration demo * [docs] Linter appeasement * [useMediaQuery] Linter appeasment * [useMediaQuery] Linter appeasment Arguable if this is actual linter appeasment. The statement about is not valueable. effects are not exectured on the server anyway so there is no performance gain. only noise in the code * [useMediaQuery] Remove redundant bailout * [useMediaQuery] perf optimization for repeated renders window.matchMedia was called on every render for defaultValue. We now only call it on state initialization. * [makeStyles] Lint appeasment * [withStyles] Linter appeasement * [docs] Fix broken LinearDeterminate demo * [docs] Linter appeasment Makes for cleaner architecture though. Previously `state` mixed input values and labelWidth. Now the concerns are clearly separated * [docs] Fix LinearBuffer demo Same approach as https://overreacted.io/making-setinterval-declarative-with-react-hooks/ * [docs] Add warning about useWidth demo * [docs} Fix broken scroll logic Closes #14628 * [TrapFocus] Fix potential bug when props are dynamic * [makeStyles] Disable hook rules I suspect that there is a bug related to hooks usage. Need to investigate
* fix: remove colors property from LinkProps * [docs] Update Link color values
* [ci] Fix size snapshot including peer dependencies * [ci] Add margin between size diff and emoji * [ci] Use wildcard import instead of named import Just creates diff noise if additional imports are used. There are little to no benefits for named imports in node
* [docs] Cleanup Demo code related to iframe * [docs] Improve demo source discoverability * [docs] Show "Show Source" tooltip before first interaction * Use max-age instead of expires for cookie Co-Authored-By: eps1lon <[email protected]> * [docs] knowsAboutShowSource -> sourceHintSeen
* [ci] Don't use offline cache anymore Network problems should be resolved * [ci] CI user *-browsers docker image instead of apt install * [ci] Move docs:api to test_build - moves docs/ related tasks together - reduces build time for test_browser which is currently the bottleneck to test_regressions * [ci] Use 2.1 commands * [ci] Use most recent yarn cache if lockfile changed Co-Authored-By: eps1lon <[email protected]> * [ci] Lint without cache in CI It'll be invalidated on every run anyway since it looks at mtime and that changes with every checkout
* [Tooltip] Use background opacity instead of opacity and increase font weight on desktop to improve readability * Calculate the tooltip color with fade
* [docs] Fix demo source tooltip being shown on small screens * [docs] Show demo actions tooltip below app bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.