fix(composer): prevent race condition when downloading binary concurrently#1544
Merged
azjezz merged 1 commit intocarthage-software:mainfrom Mar 30, 2026
Merged
Conversation
…ently Add flock-based locking to ensure_binary() so concurrent mago invocations don't conflict when downloading the same binary.
b2a65af to
09d48c9
Compare
Member
|
Internal is growing, i'm wondering what would be the breaking point where i just pull Psl :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
magoprocesses start simultaneously (e.g. parallel CI jobs, editor + CLI), both detect the binary is missing and start downloading to the same path. The second process fails because it conflicts with the first's in-progress download or extraction.locked()helper that usesflock(LOCK_EX)for cross-process mutual exclusion.ensure_binary()now acquires a per-triple lock file before downloading, so the second process blocks until the first finishes, then sees the binary already exists and skips the download entirely (double-checked locking pattern)..mago-{$triple}.lock), so downloads for different platforms never block each other.How it works
{$releaseDir}/.mago-{$triple}.lockviaflock(LOCK_EX). This is a blocking call: if another process holds the lock, the kernel suspends the caller until the lock is released (no polling or busy-waiting).finallyblock, even on failure