Skip to content

Conversation

@Rexios80
Copy link
Contributor

No description provided.

Rexios80 and others added 3 commits May 10, 2022 18:41
Pedantic tweak to use the term arm64 in place of M1, since presumably
(hopefully) we'll see further iterations of Apple Silicon Macs such as
M2, etc.

Added a bit more detail to the doc comments for both the SDK
architecture selection function and the Dartium architecture selection
function.
The chance that anyone is actually using Dartium or Content Shell, and
thus Dart 1.x in 2022 is pretty slim, but adding this for completionism
and for the fun factor of jumping in the time machine and paying a visit
to Dart's origins in Chromium.

Older versions of Dartium were time-limited to stop working after some
fixed amount of time due to the security implications of running an
out-of-date browser with two VMs running simultaneously and memory leaks
galore. My recollection is that later versions of Dartium removed this
time limit in order to give Dart 1.x users time to migrate to Dart 2, so
those are likely usable even today.
@cbracken
Copy link
Owner

Thank you very much for your patch! This looks great!

I've added a couple tiny tweaks in two followup commits:

  1. Use arm64 in place of M1 and update comments
    Pedantic tweak to use the term arm64 in place of M1, since presumably (hopefully) we'll see further iterations of Apple Silicon Macs such as M2, etc.

    Also added a bit more detail to the doc comments for both the SDK architecture selection function and the Dartium architecture selection function.

  2. Support downloading Dartium on arm64 Macs
    The chance that anyone is actually using Dartium or Content Shell, and thus Dart 1.x in 2022 is pretty slim, but adding this for completionism and for the fun factor of jumping in the time machine and paying a visit to Dart's origins in Chromium.

    Older versions of Dartium were time-limited to stop working after some fixed amount of time due to the security implications of running an out-of-date browser with two VMs running simultaneously and memory leaks galore. My recollection is that later versions of Dartium removed this time limit in order to give Dart 1.x users time to migrate to Dart 2, so those are likely usable even today.

@cbracken cbracken merged commit 5d751ad into cbracken:master May 11, 2022
@cbracken
Copy link
Owner

Not bad timing either; finally landed support for building Flutter engine on Apple Silicon Macs this morning in flutter/engine#33244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants