Framework and Carthage Support #454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gus, here is version 2.6 pull request, which introduces framework support (akin to that of the
swiftFrameworksbranch, though with even more modest changes), as well as taking it the next step and introducing Carthage support (i.e. added two shared targets that build MacOS and iOS frameworks, respectively). I tried to update the change log to indicate the nature of the non-backward compatible change, but if you think we need something more explicit, let me know.I haven't touched the Cocoapods stuff (other than bumping version), so perhaps we need someone more familiar with Cocoapods take a look at that.
I also haven't touched the static library targets (I'd vote for removing them to eliminate confusion, but that's your call). I'd also suggesting removing the command line target and
main.m, too, because IMHO that's (a) confusing; and (b) is falling out of date).On an unrelated topic, the Swift variadic extension for
FMDatabasepredates theexecuteUpdate:values:error:method that we added for Swift 2, so I've changed that it use thevaluesrendition and throw errors. It's a non-backward compatible change (it changes this variadic extension to throw errors), but it's a good thing. Frankly, I would advise just removing it altogether, though, as I think the newtry db.executeUpdate("INSERT INTO ...", values ["foo", "bar"])syntax is sufficiently concise that it eliminates the need for this variadic extension. And variadic methods are so un-Swift (though the language supports it). But, I know you love your variadic methods, so if you want to keep this tweaked extension, I'm fine with that.