Add support for specifying a custom tokenizer on the NaiveBayes model #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, it may be useful to allow people to specify their own tokenizer in the same way as the sanitizer. The tokenizer can not be added to the "constructor" function since that would break API compatibility, so add a public setter instead.
Owner
|
Hey thanks a bunch!!! And sorry this took so long to get integrated my notification got buried under a bunch of other emails 😨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it may be useful to allow people to specify their own tokenizer in the same way as the sanitizer. The tokenizer can not be added to the "constructor" function since that would break API compatibility, so add a public setter instead.
The primary use case for this is to allow people to pre-process the tokens, for example, by running the tokens through a stemmer. Without support for a custom tokenizer, the only way to accomplish this is to split, stem and re-join the sentence only to be split again which is suboptimal.