This repository was archived by the owner on May 7, 2021. It is now read-only.
Emergency Fix - Don't count non-CAFC referrals #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2020 07:50
ngosset
requested review from
davidheerema,
kevinyang06,
khalidelaggan and
sastels
ngosset
changed the title
sastels
reviewed
Mar 13, 2020
| } else { | ||
| availableData.numberOfRequests += 1 | ||
| availableData.lastRequested = new Date() | ||
| var referrer = req.headers.referer |
Contributor
There was a problem hiding this comment.
should this be req.headers.referrer?
Contributor
Author
There was a problem hiding this comment.
Probably, but it works??
https://en.wikipedia.org/wiki/HTTP_referer
"The HTTP referer (a misspelling of referrer[1]) is an optional HTTP header field that identifies the address of the webpage (i.e. the URI or IRI) which is linked to the resource being requested. By checking the referrer, the new webpage can see where the request originated."
sastels
approved these changes
Mar 13, 2020
Contributor
sastels
left a comment
sastels
left a comment
There was a problem hiding this comment.
tested locally as described. 👍
davidheerema
approved these changes
Mar 13, 2020
Contributor
davidheerema
left a comment
davidheerema
left a comment
There was a problem hiding this comment.
I reproduced the test environment by building a docker image from this branch, and running it (along with the nginx container for testing). and I received the expected test results:
docker image build -t rac:1.0 .
Maryses-MacBook-Air:f2 david$ docker container run --publish 3000:3000 --env-file ./.env.example --name deef rac:1.0
Availability configured
Self harm word list: agile,lean,mvp,scrum
Warning: CosmosDB not configured. Data will not be saved to CosmosDB database. Please set the environment variables COSMOSDB_NAME and COSMOSDB_KEY
WARNING: File storage not configured
WARNING: Azure content moderator not configured
WARNING: Notify environment variable NOTIFY_API_BASE_URL is missing. Emailing links will probably not work.
WARNING: Notify environment variable NOTIFY_CONFIRMATION_TEMPLATE_ID is missing. Emailing links will probably not work.
Notify client NOT created
Listening at port 3000
Referrer:http://localhost/
New Request. {"numberOfSubmissions":0,"numberOfRequests":0}
Referrer:http://centreantifraude.ca/
New Request. {"numberOfSubmissions":0,"numberOfRequests":1,"lastRequested":"2020-03-13T14:21:18.565Z"}
Referrer:http://centreantifraude.ca/
New Request. {"numberOfSubmissions":0,"numberOfRequests":2,"lastRequested":"2020-03-13T14:21:48.796Z"}
Referrer:http://localhost/
New Request. {"numberOfSubmissions":0,"numberOfRequests":2,"lastRequested":"2020-03-13T14:21:48.796Z"}
Referrer:http://localhost/
New Request. {"numberOfSubmissions":0,"numberOfRequests":2,"lastRequested":"2020-03-13T14:21:48.796Z"}
Contributor
|
Looks great! |
davidheerema
added a commit
that referenced
this pull request
Mar 27, 2020
* FIX CORS for HTTPS (#1665) Yesterday CAFC moved to HTTPS, this broke our allowed origins. * Emergency Fix - Don't count non-CAFC referrals (#1672) * Only count referrers from CAFC * Fixed typo * Referrer urls are less predictable than origin? Just look at the host portion * temporarily enable request debugging (#1673) Co-authored-by: ngosset <[email protected]> Co-authored-by: dhcdn <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a counter of about 1 hour between requests. Only after the hour has passed do we redirect a person from CAFC.
This is a problem because we reset the counter every time the web application is visited. An Internal mechanism from Azure seems to be "visiting" our site every 5 minutes and resetting the counter. This doesn't show up in our App Service HTTPLogs so it must be an internal mechanism.
Because of this we are effectively not taking any redirects.
This PR adds a check for the referrer to verify the traffic is coming from CAFC before incrementing the counter.
How to test:
To test:
Step 1:
Add a fake DNS entry to your hosts. This makes it so a url points to the web server on YOUR computer.
On Mac OS: edit the file /private/etc/hosts
And add the following entry:
127.0.0.1 centreantifraude.ca
Step 2:
Flush your DNS cache
sudo killall -HUP mDNSResponder
Step 3: Create a static page with a link to the app:
Step 4:
Start a web server on your local machine that serves the static page
Example:
docker run --name nginx -p 80:80 -v /Users/normangosset/projects/fakesite:/usr/share/nginx/html:ro -d nginx
Step 5:
Make sure you are running server.js locally on port 3000
Navigate to http://localhost:80 and click "click me". You should see the following in the console:
Referrer:http://localhost/
New Request. {"numberOfSubmissions":0,"numberOfRequests":0}
Navigate to http://centreantifraude.ca:80 and click :"click me". You should see the following in console:
Referrer:http://centreantifraude.ca/
New Request. {"numberOfSubmissions":0,"numberOfRequests":1,"lastRequested":"2020-03-13T12:25:16.993Z"}