{synapse} az synapse module migration to Microsoft Graph (Azure#23098)

* make changes to use ms graph

* fix comment

* fix test issue

* fix pipeline test issue

* remove unused error

* fix style error

* fix wrong usage

src/azure-cli/azure/cli/command_modules/synapse/manual/_client_factory.py

@@ -152,16 +152,9 @@ def cf_synapse_role_definitions(cli_ctx, workspace_name):
 
 
 def cf_graph_client_factory(cli_ctx, **_):
-    from azure.cli.core._profile import Profile
-    from azure.cli.core.commands.client_factory import configure_common_settings
-    from azure.graphrbac import GraphRbacManagementClient
-    profile = Profile(cli_ctx=cli_ctx)
-    cred, _, tenant_id = profile.get_login_credentials(
-        resource=cli_ctx.cloud.endpoints.active_directory_graph_resource_id)
-    client = GraphRbacManagementClient(cred, tenant_id,
-                                       base_url=cli_ctx.cloud.endpoints.active_directory_graph_resource_id)
-    configure_common_settings(cli_ctx, client)
-    return client
+    from azure.cli.command_modules.role import graph_client_factory
+    graph_client = graph_client_factory(cli_ctx)
+    return graph_client
 
 
 def cf_synapse_client_artifacts_factory(cli_ctx, workspace_name):

src/azure-cli/azure/cli/command_modules/synapse/manual/operations/accesscontrol.py

@@ -6,8 +6,7 @@
 from knack.util import CLIError
 from azure.cli.core.azclierror import InvalidArgumentValueError, ArgumentUsageError
 from azure.cli.core.util import is_guid
-from azure.graphrbac.models import GraphErrorException
-from msrestazure.azure_exceptions import CloudError
+from azure.cli.command_modules.role import GraphError
 from .._client_factory import cf_synapse_role_assignments, cf_synapse_role_definitions, cf_graph_client_factory
 from ..constant import ITEM_NAME_MAPPING
 import azure.cli.command_modules.synapse.custom_help as cust_help
@@ -121,12 +120,12 @@ def _resolve_object_id(cmd, assignee, fallback_to_object_id=False):
     client = cf_graph_client_factory(cmd.cli_ctx)
     result = None
     try:
-        result = list(client.users.list(filter="userPrincipalName eq '{0}' or mail eq '{0}' or displayName eq '{0}'"
-                                        .format(assignee)))
+        result = list(client.user_list(filter="userPrincipalName eq '{0}' or mail eq '{0}' or displayName eq '{0}'"
+                                       .format(assignee)))
         if not result:
-            result = list(client.service_principals.list(filter="displayName eq '{}'".format(assignee)))
+            result = list(client.service_principal_list(filter="displayName eq '{}'".format(assignee)))
         if not result:
-            result = list(client.groups.list(filter="mail eq '{}'".format(assignee)))
+            result = list(client.group_list(filter="mail eq '{}'".format(assignee)))
         if not result and is_guid(assignee):  # assume an object id, let us verify it
             result = _get_object_stubs(client, [assignee])
 
@@ -141,20 +140,20 @@ def _resolve_object_id(cmd, assignee, fallback_to_object_id=False):
                            "Please using --assignee-object-id GUID to specify assignee accurately"
                            .format(assignee=assignee))
 
-        return result[0].object_id
-    except (CloudError, GraphErrorException):
+        return result[0]["id"]
+    except GraphError:
         if fallback_to_object_id and is_guid(assignee):
             return assignee
         raise
 
 
 def _get_object_stubs(graph_client, assignees):
-    from azure.graphrbac.models import GetObjectsParameters
     result = []
     assignees = list(assignees)  # callers could pass in a set
     for i in range(0, len(assignees), 1000):
-        params = GetObjectsParameters(include_directory_object_references=True, object_ids=assignees[i:i + 1000])
-        result += list(graph_client.objects.get_objects_by_object_ids(params))
+        body = {"ids": assignees[i:i + 1000],
+                "types": ['user', 'group', 'servicePrincipal', 'directoryObjectPartnerReference']}
+        result.extend(list(graph_client.directory_object_get_by_ids(body)))
     return result