Skip to content
This repository was archived by the owner on Dec 13, 2022. It is now read-only.

fix(secu) remove unused params or sanitize them in service by SG pages #8043

Merged
sc979 merged 4 commits into from
Oct 24, 2019
Merged

fix(secu) remove unused params or sanitize them in service by SG pages #8043

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82befbb
style
sc979 Oct 23, 2019
7a2e62d
fix(secu): remove unused http parameters in serviceGridBySGXML file
sc979 Oct 23, 2019
13165df
style
sc979 Oct 23, 2019
1bff2fa
fix(secu): remove unused http parameters in serviceSummaryBySGXML file
sc979 Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(secu): remove unused http parameters in serviceGridBySGXML file
  • Loading branch information
@sc979
sc979 committed Oct 23, 2019
commit 7a2e62dfd6d4021dde8027ca9769058dc9f40cc1
37 changes: 27 additions & 10 deletions www/include/monitoring/status/ServicesServiceGroups/xml/serviceGridBySGXML.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,36 @@
// Set Default Poller
$obj->getDefaultFilters();

// Check Arguments From GET tab
/*
* Check Arguments from GET and session
*/
// integer values from $_GET
$p = filter_input(INPUT_GET, 'p', FILTER_VALIDATE_INT, array('options' => array('default' => 2)));
$num = filter_input(INPUT_GET, 'num', FILTER_VALIDATE_INT, array('options' => array('default' => 0)));
$limit = filter_input(INPUT_GET, 'limit', FILTER_VALIDATE_INT, array('options' => array('default' => 20)));

$order = filter_input(
INPUT_GET,
'order',
FILTER_VALIDATE_REGEXP,
array(
'options' => array(
'default' => "ASC",
'regexp' => '/^(ASC|DESC)$/'
)
)
);

// string values from the $_GET sanitized using the checkArgument() which call CentreonDB::escape() method
$o = $obj->checkArgument("o", $_GET, "h");
$p = $obj->checkArgument("p", $_GET, "2");
$nc = $obj->checkArgument("nc", $_GET, "0");
$num = $obj->checkArgument("num", $_GET, 0);
$limit = $obj->checkArgument("limit", $_GET, 20);
$instance = $obj->checkArgument("instance", $_GET, $obj->defaultPoller);
$hostgroup = $obj->checkArgument("hostgroups", $_GET, $obj->defaultHostgroups); // not used
$hSearch = $obj->checkArgument("host_search", $_GET, "");
$sgSearch = $obj->checkArgument("sg_search", $_GET, "");
$sort_type = $obj->checkArgument("sort_type", $_GET, "host_name");
$order = $obj->checkArgument("order", $_GET, "ASC");
$dateFormat = $obj->checkArgument("date_time_format_status", $_GET, "Y/m/d H:i:s");

// values saved in the session
$instance = filter_var($obj->defaultPoller, FILTER_VALIDATE_INT);
$hostgroup = filter_var($obj->defaultHostgroups, FILTER_VALIDATE_INT);
$dateFormat = "Y/m/d H:i:s";

// Backup poller selection
$obj->setInstanceHistory($instance);
Expand Down Expand Up @@ -117,7 +134,7 @@
$query .= $s_search;

// Poller search
if ($instance != -1) {
if (!empty($instance) && $instance !== -1) {
$query .= " AND h.instance_id = " . (int)$instance . " ";
}

Expand Down