Fix test broken on recent versions of enzyme #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running against versions of enzyme > 3.3.0, one of the frontend tests fails. The test actually had an error: it was erroneously trying to select a <button class=".o-expandable_cue"> using a ".o-expandable_cue button" selector. This worked in enzyme <= 3.3.0 but was fixed in 3.4.0, in enzymejs/enzyme#1680. See this comment for someone else encountering the same thing: enzymejs/enzyme#1680 (comment) To test, disable the use of package-lock with "npm config set package-lock false", then run "npm install", then "npm test". This will fail without the test to the change and pass with this change. Thanks to @wpears for assistance with this.
Scotchester
pushed a commit
that referenced
this pull request
Jul 20, 2020
Fix test broken on recent versions of enzyme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running against versions of enzyme > 3.3.0, one of the frontend tests fails. The test actually had an error: it was erroneously trying to select a
<button class=".o-expandable_cue">using an".o-expandable_cue button"selector. This worked in enzyme <= 3.3.0 but was fixed in 3.4.0, in enzymejs/enzyme#1680.See this comment for someone else encountering the same thing:
enzymejs/enzyme#1680 (comment)
To test, disable the use of package-lock with
"npm config set package-lock false", then run"npm install", then"npm test". This will fail without the test to the change and pass with this change.Thanks to @wpears for assistance with this.