Skip to content

Switch to pyproject.toml and add a tox -e interactive environment #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Switch to pyproject.toml and add a tox -e interactive environment #71

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a478e5
Switch to pyproject.toml
willbarton Jan 11, 2023
0814b0d
Add interactive tox environment
willbarton Jan 11, 2023
17e7d9c
Update release to PyPI workflow
willbarton Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update release to PyPI workflow
  • Loading branch information
@willbarton
willbarton committed Jan 12, 2023
commit 17e7d9c20e1bb175266a853976e3fd02a03227a0
16 changes: 9 additions & 7 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,28 @@
name: Publish to PyPI
on:
on:
release:
types: [published]
workflow_dispatch:


jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2
Copy link
Member

@anselmbradford anselmbradford Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3 is out. Can this use actions/checkout@v3? https://github.com/actions/checkout/releases/tag/v3.3.0

- name: Set up Python
uses: actions/setup-python@v1
uses: actions/setup-python@v4
with:
python-version: 3.7
python-version: 3.11
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install --upgrade pip build
pip install twine wheel
Copy link
Member

@chosak chosak Jan 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install twine wheel
pip install twine

Is wheel needed here? From using python -m build (very cool, by the way, TIL this is a thing), it looks like the build package handles that install itself in an isolated environment.

- name: Build the package
run: |
python setup.py sdist bdist_wheel --universal
python -m build
- name: Upload to PyPI
run: twine upload dist/*
env:
env:
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}