Support Wagtail >= 4, drop support for Wagtail < 4 #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With [PEP 621 support added to setuptools](pypa/setuptools#2970) last year, and with pip supporting editable installs as of 21.3, we can move to `pyproject.toml` and deprecate `setup.py`. The file remains for legacy pip support. Because [flake8 does not want to support pyproject.tml yet](PyCQA/flake8#234), unlike all the other tools we use, I’m removing it in favor of [ruff](https://github.com/charliermarsh/ruff). Co-authored-by: Andy Chosak <[email protected]>
This commit adds a new `tox -e interactive` that runs a local test server, to make it easier to test this project. This is a feature that [wagtail-localize](https://www.wagtail-localize.org/#how-to-run-tests) has that we’ve also added to [wagtail-inventory](https://github.com/cfpb/wagtail-inventory#testing) and [wagtail-treemodeladmin](https://github.com/cfpb/wagtail-treemodeladmin). 🎩 to @chosak for this pattern. Co-authored-by: Andy Chosak <[email protected]>
This change adds the flag icon from CFPB’s [Design System](https://cfpb.github.io/design-system/foundation/iconography) as a custom icon, and uses it in the Wagtail admin.
This change adds Wagtail 4 breadcrumbs and header changes, updates the Wagtail admin styled forms, and makes some minor wording modifications. It also moves edit-condition title logic from the template to the view.
chosak
reviewed
Jan 26, 2023
chosak
approved these changes
Mar 7, 2023
chosak
reviewed
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support for Wagtail versions < 4, and adds support for Wagtail 4.0+. This requires, primarily, template changes to match the upstream changes in the Wagtail admin.
This PR also changes the icon to the CFPB "flag" icon.
Note: currently this PR includes the commits from #71. Once that PR is merged, I'll rebase on
main.