configures redirectTo to accept regex #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austince
suggested changes
Apr 16, 2019
Contributor
|
Also, just want to say thanks for the PR and looks good! |
Author
|
No problem! Happy to help 😎 |
Contributor
|
👍 Would you mind also updating the signature in the Readme? |
austince
approved these changes
Apr 16, 2019
Contributor
austince
left a comment
austince
left a comment
There was a problem hiding this comment.
I think this looks good! Let's see what others have to say
keithamus
reviewed
Apr 17, 2019
This comment has been minimized.
This comment has been minimized.
austince
approved these changes
Apr 17, 2019
This was referenced Apr 17, 2019
Merged
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #235