Skip to content

ci: correctly template github event in if condition for release #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2021
Merged

ci: correctly template github event in if condition for release #283

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e755977
ci: correctly template github event in if condition for release
austince Feb 24, 2021
fb7cc86
add comment for NPM token name
keithamus Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- uses: coverallsapp/[email protected]
with:
github-token: ${{ secrets.github_token }}


publish-npm:
needs: build
Expand All @@ -40,7 +40,7 @@ jobs:
node-version: 12
registry-url: https://registry.npmjs.org/
- run: npm run release
if: github.event == 'push'
if: ${{ github.event == 'push' }}
env:
NPM_TOKEN: ${{secrets.NPM_TOKEN}}
GITHUB_TOKEN: ${{secrets.github_token}}