fix(attestation): fix deduplication of policy evaluations#3016
Open
jiparis wants to merge 2 commits intochainloop-dev:mainfrom
Open
fix(attestation): fix deduplication of policy evaluations#3016jiparis wants to merge 2 commits intochainloop-dev:mainfrom
jiparis wants to merge 2 commits intochainloop-dev:mainfrom
Conversation
…d-trip Replace reflect.DeepEqual with maps.Equal for policy evaluation dedup so nil and empty maps are treated as equivalent. protojson.Marshal omits empty maps, causing deserialized With fields to be nil instead of empty, which made the dedup comparison fail and duplicate evaluations appear. Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
jiparis
changed the title
migmartri
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reflect.DeepEqualwithmaps.Equalfor policy evaluation deduplication so thatniland empty maps are treated as equivalentpolicyEvalMatcheshelper to encapsulate the comparison logic used at both dedup sitesContext
All trace attestations evaluate policies twice (init + push phases). After protojson round-trip serialization, the
Withfield changes frommap[string]string{}tonilbecause protojson omits empty maps.reflect.DeepEqualtreats these as different, causing the dedup to fail and duplicate evaluations to appear in attestation results.Closes #3017