Skip to content

dec30 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 31, 2016
Merged

dec30 #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b8505c
Update style.css
antibland Dec 23, 2016
0c3e82a
Merge pull request #73 from antibland/patch-1
wesbos Dec 24, 2016
561b33b
add missing comma
aaemnnosttv Dec 24, 2016
a266831
Merge pull request #75 from aaemnnosttv/pr/04-missing-comma
wesbos Dec 24, 2016
3eddb45
Accessibility fix: Added id attribute to input elements that equals t…
adildostmohamed Dec 25, 2016
8010f0f
Merge pull request #76 from adildostmohamed/bug/accessiblity-03
wesbos Dec 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Accessibility fix: Added id attribute to input elements that equals t… 
…he for attribute of the corresponding label element so that correct label is read out to screenreader when input is focussed on and puts focus on input element if the corresponding label is clicked
  • Loading branch information
@adildostmohamed
adildostmohamed committed Dec 25, 2016
commit 3eddb459014b0042241fd455c61c3e75183ee9b7
6 changes: 3 additions & 3 deletions 03 - CSS Variables/index-FINISHED.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ <h2>Update CSS Variables with <span class='hl'>JS</span></h2>

<div class="controls">
<label for="spacing">Spacing:</label>
<input type="range" name="spacing" min="10" max="200" value="10" data-sizing="px">
<input id="spacing" type="range" name="spacing" min="10" max="200" value="10" data-sizing="px">

<label for="blur">Blur:</label>
<input type="range" name="blur" min="0" max="25" value="10" data-sizing="px">
<input id="blur" type="range" name="blur" min="0" max="25" value="10" data-sizing="px">

<label for="base">Base Color</label>
<input type="color" name="base" value="#ffc600">
<input id="base" type="color" name="base" value="#ffc600">
</div>

<img src="https://source.unsplash.com/7bwQXzbF6KE/800x500">
Expand Down
6 changes: 3 additions & 3 deletions 03 - CSS Variables/index-START.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ <h2>Update CSS Variables with <span class='hl'>JS</span></h2>

<div class="controls">
<label for="spacing">Spacing:</label>
<input type="range" name="spacing" min="10" max="200" value="10" data-sizing="px">
<input id="spacing" type="range" name="spacing" min="10" max="200" value="10" data-sizing="px">

<label for="blur">Blur:</label>
<input type="range" name="blur" min="0" max="25" value="10" data-sizing="px">
<input id="blur" type="range" name="blur" min="0" max="25" value="10" data-sizing="px">

<label for="base">Base Color</label>
<input type="color" name="base" value="#ffc600">
<input id="base" type="color" name="base" value="#ffc600">
</div>

<img src="https://source.unsplash.com/7bwQXzbF6KE/800x500">
Expand Down