Skip to content

Fix resolving of absolute URLs #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noerw wants to merge 5 commits into from
Closed

Fix resolving of absolute URLs #96

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb1296a
fix URL resolve
noerw Dec 16, 2020
f0a29f1
Merge remote-tracking branch 'origin/master' into fix-url-resolve
noerw Mar 5, 2021
c04d080
add tests
noerw Mar 6, 2021
f76a1d9
Add tests for local files and Github base URLs
muesli Mar 31, 2021
ae063a5
Merge remote-tracking branch 'upstream/master' into fix-url-resolve
noerw Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests for local files and Github base URLs
  • Loading branch information
@muesli
muesli committed Mar 31, 2021
commit f76a1d91ac66529304b9dc4e0d1011910f1c07d6
17 changes: 17 additions & 0 deletions ansi/renderer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,13 @@ func TestUrlResolver(t *testing.T) {
assertEqual(t, resolveURL(host+"/a/b/", host2+"/c/d"), host2+"/c/d")
}

func TestUrlResolverForLocalFiles(t *testing.T) {
base := "/home/foobar/project/"
assertEqual(t,
resolveURL(base, "/assets/logo.png"),
"/home/foobar/project/assets/logo.png")
}

func TestUrlResolverForGitforgeUsage(t *testing.T) {
// in git-forges like github & gitea, URLs are often written relative,
// where the repo-url (`gitea.com/gitea/tea`) treated as reference.
Expand All @@ -206,6 +213,16 @@ func TestUrlResolverForGitforgeUsage(t *testing.T) {
assertEqual(t,
resolveURL(base, "src/branch/master/modules/print/markdown.go"),
"https://gitea.com/gitea/tea/src/branch/master/modules/print/markdown.go")

base = "https://raw.githubusercontent.com/foo/bar/master/"
assertEqual(t,
resolveURL(base, "/assets/logo.png"),
"https://raw.githubusercontent.com/foo/bar/master/assets/logo.png")

base = "https://raw.githubusercontent.com/foo/bar/master/some/dir/"
assertEqual(t,
resolveURL(base, "/assets/logo.png"),
"https://raw.githubusercontent.com/foo/bar/master/assets/logo.png")
}

func assertEqual(t *testing.T, value interface{}, expected interface{}) {
Expand Down