Skip to content

Improve scale fitting logic and performance #6074

@benmccann

Description

@benmccann
  • core.layouts calls scale.update multiple times. This is unnecessary. We do not need to calculate the ticks multiple times for example. We should instead call fit rather than update
  • fit, autoSkip, and calculateTickRotation do not work well together
    • There's some trade-off between auto-skipping and label rotation. It's unclear how these relate. Clarification proposed in Improve autoSkip documentation #6079
    • _autoSkip should probably happen in update rather than draw. Right now fit assumes all ticks will be drawn, which isn't true when autoSkip: true

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions