Skip to content

Respect fill: false with custom draw times #10414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 22, 2022
Merged

Respect fill: false with custom draw times #10414

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2e1e028
Resolve canvasgradient is not defined in node
LeeLenaleee Apr 29, 2022
733fe22
Remove trailing white space
LeeLenaleee Apr 29, 2022
6a6270f
export isPaternOrGradient helper with typings
LeeLenaleee May 2, 2022
079f690
fix lint failure, single qoute
LeeLenaleee May 2, 2022
e36e13e
Respect `fill: false` with custom draw times
LeeLenaleee Jun 9, 2022
fcc9a10
resolve merge conflict
LeeLenaleee Jun 9, 2022
d4438da
correctly listen to fill property
LeeLenaleee Jun 9, 2022
82d83e7
remove console log and lint errors
LeeLenaleee Jun 9, 2022
959e2ca
implement feedback, still update control points
LeeLenaleee Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Resolve canvasgradient is not defined in node
  • Loading branch information
@LeeLenaleee
LeeLenaleee authored Apr 29, 2022
commit 2e1e0280af3a64cada919e658d30b509a6fb8df2
9 changes: 8 additions & 1 deletion src/helpers/helpers.color.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import colorLib from '@kurkle/color';

const isPatternOrGradient = (value) => value instanceof CanvasGradient || value instanceof CanvasPattern;
const isPatternOrGradient = (value) => {
if (value && typeof value === 'object') {
const type = value.toString();
return type === '[object CanvasPattern]' || type === '[object CanvasGradient]';
}

return false;
};

export function color(value) {
return isPatternOrGradient(value) ? value : colorLib(value);
Expand Down