Skip to content

Return correct label for value type axis #5920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 17, 2019
Merged

Return correct label for value type axis #5920

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3d6e5d1
Return correct label for value type axis
kurkle Dec 16, 2018
a170bab
update comments
kurkle Jan 10, 2019
e286063
fix typo
kurkle Jan 10, 2019
969639f
modify comment
kurkle Jan 10, 2019
08b101b
Make sure assumption is right.
kurkle Jan 13, 2019
89852d8
Alias data, cache value with index check
kurkle Jan 13, 2019
dc8a686
make isHorizontal matter for object data too.
kurkle Jan 13, 2019
4abdc59
move getValueScale + friends up to DatasetController
kurkle Jan 15, 2019
bacc5e9
prefix moved private methods with underscore
kurkle Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
@kurkle
kurkle committed Jan 13, 2019
commit e28606310d40b5aef44d07040d198cae5f2f6892
2 changes: 1 addition & 1 deletion src/scales/scale.category.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ module.exports = Scale.extend({

// For scales supporting getValueScaleId, we can be sure if this is a value scale.
// For others, vertical scale is assumed to be value.
// Note: This assumptiom works correctly for all charts with {x,y} data,
// Note: This assumption works correctly for all charts with {x,y} data,
// because getRightValue returns correct thing regardless if its a label or value.
var isValueScale = ds.getValueScaleId
? ds.getValueScaleId() === me.id
Expand Down