Remove date auto type conversions #5982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
previously approved these changes
Jan 15, 2019
simonbrunel
requested changes
Jan 16, 2019
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
While I agree with the changes in adapter.moment.js (and Date.now()), I don't think there is any good reason to remove the + to cast to number in scale.time.js.
kurkle
approved these changes
Jan 17, 2019
etimberg
approved these changes
Jan 17, 2019
simonbrunel
approved these changes
Jan 17, 2019
Closed
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were mostly no-ops now that we have timestamps
new Date().getTime()is more than twice as fast as+new Date()andDate.now()faster still. https://jsperf.com/new-date-timingIt also appears to be faster not to use
+momentas well. https://jsperf.com/moment-getvalueRelated to #5960