Fix duplicate anchor #6038
Merged
Fix duplicate anchor #6038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
previously approved these changes
Feb 2, 2019
simonbrunel
reviewed
Feb 2, 2019
benmccann
force-pushed
the
duplicate-anchor
branch
from
6c6f590 to
4360e0e
Compare
simonbrunel
requested changes
Feb 4, 2019
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Good catch for the root anchor, it should be only one # (h1) per page.
benmccann
force-pushed
the
duplicate-anchor
branch
from
4bf12e0 to
1025af8
Compare
simonbrunel
approved these changes
Feb 4, 2019
kurkle
approved these changes
Feb 4, 2019
etimberg
approved these changes
Feb 5, 2019
janelledement
pushed a commit
to janelledement/Chart.js
that referenced
this pull request
Feb 10, 2019
* Fix broken documentation anchors * Revert changes to installation docs
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* Fix broken documentation anchors * Revert changes to installation docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anchors aren't generated for
h1tags. I first tried configuring gitbook to generate anchors forh1tags, but it was quite strange to have anchor tags generated for the page header, which is probably why the default does not include them. So instead I went through and changed all the single#tags that weren't the page header to##, etc. as appropriateIn updating the installation page, I reordered a bit. It seemed useful for users to know which file to grab before they go to fetch it from a CDN. We only want to encourage selecting the build yourself when using a CDN because if you're using the package it should be selected for you using
package.json'smainattribute, so I moved it under the CDN sectionAlso, the link https://www.chartjs.org/docs/latest/charts/bar.html#dataset-properties does not work because there are two instances on the page and it always takes you to the first, so the duplicate anchor was removed as suggested by @simonbrunel