Fix unit determination when autoSkip is enabled #6583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
autoskip-unit
branch
from
1fa3768 to
2933bcf
Compare
benmccann
force-pushed
the
autoskip-unit
branch
from
2933bcf to
71aac69
Compare
kurkle
approved these changes
Oct 23, 2019
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
I did not do a through testing, but I'm confident this does not make it worse :)
etimberg
approved these changes
Oct 24, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
Open
This was referenced Jul 5, 2021
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
determineUnitForFormattingdoesn't work well whenautoSkipis enabled because it relies on the number of ticks, which changes when the autoSkip is applied. Now that autoSkip is aware of major ticks this is a more noticeable issueI removed a division by 2. Two test failed without this change, but changing it also meant I had to change a couple other tests. It's somewhat subjective as to what produces better results. However, I felt this produced better results for the related tests. I could not find a compelling reason as to why this division was introduced in the first place and it seemed somewhat arbitrary to do it. The number of ticks in the test is larger because it switched from days to hours (so x 24) and it's before autoSkip is applied. After autoSkip the number of ticks doesn't change all that much
Before
After