[2.9] Stop unnecessary line calculations #6671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
changed the title
etimberg
approved these changes
Nov 2, 2019
kurkle
approved these changes
Nov 2, 2019
etimberg
pushed a commit
that referenced
this pull request
Nov 2, 2019
benmccann
added a commit
to benmccann/uPlot
that referenced
this pull request
Nov 2, 2019
I found another pretty good performance boost there: chartjs/Chart.js#6671
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 1, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Aug 16, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this today as causing quite a bit of slowdown. I'm only sending this PR against 2.9 because I noticed that #6576 fixes it as well